Skip to content

feat(clk-gateway): keep set of names reserved #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aliXsed merged 1 commit into from
Dec 19, 2024
Merged

feat(clk-gateway): keep set of names reserved #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion clk-gateway/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@
"firebase": "^11.0.2",
"firebase-admin": "^13.0.1",
"typescript": "^5.7.2",
"validator": "^13.12.0",
"zksync-ethers": "^6.15.1"
},
"devDependencies": {
"@types/cors": "^2.8.17",
"@types/express": "^5.0.0",
"@types/jest": "^29.5.14",
"@types/validator": "^13.12.2",
"jest": "^29.7.0",
"nodemon": "^3.1.7",
"prettier": "^3.3.3",
Expand All @@ -32,6 +34,7 @@
"dev": "nodemon src/index.ts",
"build": "tsc",
"serve": "yarn build && yarn start",
"createToken": "ts-node src/createToken.ts"
"createToken": "ts-node src/createToken.ts",
"createReservedNameHashes": "ts-node src/reservedNames.ts"
}
}
11 changes: 10 additions & 1 deletion clk-gateway/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import {
cnsTld,
} from "./setup";
import { getBatchInfo } from "./helpers";
import reservedHashes from "./reservedHashes";

const app = express();
app.use(express.json());
Expand Down Expand Up @@ -303,16 +304,24 @@ app.post(
"/registerL2",
[
body("name")
.isLowercase()
.withMessage("Name must be a lowercase string")
.isFQDN()
.withMessage("Name must be a fully qualified domain name")
.custom((name) => {
const [sub, domain, tld] = name.split(".");
if (domain !== cnsDomain || tld !== cnsTld) {
return false;
}

const subHash = keccak256(toUtf8Bytes(sub));
if (reservedHashes.includes(subHash)) {
return false;
}

return true;
})
.withMessage("Invalid domain or tld"),
.withMessage("Invalid domain or tld or reserved subdomain"),
body("owner")
.isString()
.custom((owner) => {
Expand Down
Loading
Loading