Skip to content

Fix heatmap save and update requirements#35

Closed
liquid-releasing wants to merge 1 commit intoNodudeWasTaken:masterfrom
liquid-releasing:pr/bugfix-and-requirements
Closed

Fix heatmap save and update requirements#35
liquid-releasing wants to merge 1 commit intoNodudeWasTaken:masterfrom
liquid-releasing:pr/bugfix-and-requirements

Conversation

@liquid-releasing
Copy link

  • Fix AttributeError: FigureCanvasTkAgg has no savefig; call savefig on figure instead of canvas
  • Remove outdated version pins in requirements.txt that prevented installation with modern Python

- Fix AttributeError: FigureCanvasTkAgg has no savefig; call savefig on figure instead of canvas
- Remove outdated version pins in requirements.txt that prevented installation with modern Python

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@liquid-releasing
Copy link
Author

Fix heatmap save and update requirements

Fixes AttributeError: 'FigureCanvasTkAgg' object has no attribute 'savefig' when saving a heatmap — savefig must be called on figure, not the canvas
Removes outdated version pins in requirements.txt (numpy<1.24, librosa==0.10.0.post2, etc.) that fail to install with modern Python

@NodudeWasTaken
Copy link
Owner

I cannot guarantee that external libraries keep the functionality that we use in their api interfaces if i dont version them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants