Replace Commander library by ArgumentParser #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphatroya
commented
Oct 2, 2020
| try ImageExtractor.extract(input: (image, platforms), output: (iconName, outputPath)) | ||
| } catch { | ||
| print("Image Extraction Error has occured 😱") | ||
| throw ExitCode(1) |
Contributor
Author
There was a problem hiding this comment.
I also think in that and L48 cases program flow should be aborted to prevent wrong success info printing
Nonchalant
approved these changes
Oct 2, 2020
Owner
Nonchalant
left a comment
Nonchalant
left a comment
There was a problem hiding this comment.
Thanks for the great suggestions!
I've been wanting to adopt swift-argument-parser myself!
I just supported Xcode12, so I'm just asking for your help in resolving conflicts here!
I'm so glad!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have courage to suggest you to replace Commander library by apple argument parser library. This library from maintainers of the Swift have better support and stability.
Also it uses new Swift 5.1 features (property wrappers) and code looks very nice (IMHO of course).
Another benefit - build in generation of the shell completions.
In this PR I tried to keep the same options and flags names to provide compatibility with your documentation.
New interface:
The old one:
