Feat/sidebar mobile #142
Merged
Feat/sidebar mobile #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
bacbe67
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4cdc29d9.nfe.pages.dev |
| Branch Preview URL: | https://feat-sidebar-mobile.nfe.pages.dev |
Bogay
approved these changes
Aug 5, 2023
uier
reviewed
Aug 5, 2023
| import { useMediaQuery } from "@vueuse/core"; | ||
|
|
||
| export default function useInteractions() { | ||
| const isDesktop = useMediaQuery("(min-width: 1024px)"); |
Member
There was a problem hiding this comment.
Since our current responsive design depends on TailwindCSS breakpoint, would it be better to use useBreakpoints ?
Member
There was a problem hiding this comment.
then, we can avoid writing "(min-width: 1024px)"
Contributor
Author
There was a problem hiding this comment.
I think that's nice. Unless we want to use different breakpoint in the future.
It can be a good first issue.
laporchen
force-pushed
the
feat/sidebar-mobile
branch
from
ae6f8f1 to
bacbe67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses commits from #141, would rebase after #141 is merged