Add NosArchive read/write for legacy .NOS containers#115
Merged
erwan-joly merged 1 commit intomasterfrom Apr 23, 2026
Merged
Conversation
Exposes a public static NosArchive type with Read(byte[]) / Write(IReadOnlyList<Entry>) handling the legacy file-list + XOR-obfuscated payload layout (NScliData_*.NOS, NSlangData_*.NOS, etc). Preserves the per-entry Id and the unknown 4-byte field verbatim so round-trips are byte-faithful after decryption. Useful for tooling that needs to rewrite strings inside conststring.dat (e.g. the NosMall URL) and repack without shelling out to external tools. Bump version to 4.1.0 (new public API). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review WalkthroughA new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NosArchivetype withRead(byte[])/Write(IReadOnlyList<Entry>)for the legacy file-list + XOR-obfuscated payload layout used byNScliData_*.NOS,NSlangData_*.NOS, etc.Idand the unknown 4-byte header field verbatim so round-trips are byte-faithful after decryption.Consumers can now rewrite strings inside inner files (e.g. the NosMall URL in
conststring.dat) and repack without shelling out to external tools like OnexExplorer.Test plan
TreatWarningsAsErrors=true+GenerateDocumentationFile=trueRead→Write→Readproduces decrypted-content-identical entries onNScliData_FR.NOS4.1.0to trigger NuGet release via.github/workflows/dotnet.yml🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
.NOSarchive files with encryption/decryption capabilities for archive contents.Chores