Skip to content

ci: grant contents:write for release asset upload#228

Merged
erwan-joly merged 1 commit intomasterfrom
ci/release-permissions
Apr 23, 2026
Merged

ci: grant contents:write for release asset upload#228
erwan-joly merged 1 commit intomasterfrom
ci/release-permissions

Conversation

@erwan-joly
Copy link
Copy Markdown
Contributor

@erwan-joly erwan-joly commented Apr 23, 2026

Same fix as NosCore.Packets#441 and NosCore.ParserInputGenerator. Ensures GITHUB_TOKEN has release-write scope.

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow permissions to improve automated release publishing.

The softprops/action-gh-release step falls back to GITHUB_TOKEN, which
under the org's default-read workflow policy lacks release-creation
scope. Add explicit job-level permissions so the tag-triggered run can
create the GitHub release alongside the NuGet push.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

The pull request adds job-scoped GitHub Actions permissions to the dotnet workflow, specifically granting contents: write access to enable the release upload step to write to repository release contents.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/dotnet.yml
Adds job-scoped contents: write permission to enable write access for release asset upload operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci: grant contents:write for release asset upload' directly and concisely describes the main change: adding GitHub Actions permissions for release asset uploads.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/release-permissions

Comment @coderabbitai help to get the list of available commands and usage tips.

@erwan-joly erwan-joly merged commit 83456c8 into master Apr 23, 2026
2 of 4 checks passed
@erwan-joly erwan-joly deleted the ci/release-permissions branch April 23, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant