Skip to content

French word list and test vectors#4

Merged
westonal merged 1 commit intomasterfrom
feature/french-word-list
Oct 8, 2017
Merged

French word list and test vectors#4
westonal merged 1 commit intomasterfrom
feature/french-word-list

Conversation

@westonal
Copy link
Copy Markdown
Member

@westonal westonal commented Oct 8, 2017

Add French #1

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 8, 2017

Codecov Report

Merging #4 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #4      +/-   ##
============================================
+ Coverage     94.52%   94.66%   +0.13%     
- Complexity       64       67       +3     
============================================
  Files             9       10       +1     
  Lines           201      206       +5     
  Branches         26       26              
============================================
+ Hits            190      195       +5     
  Misses            9        9              
  Partials          2        2
Impacted Files Coverage Δ Complexity Δ
...a/io/github/novacrypto/bip39/wordlists/French.java 100% <100%> (ø) 3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c798ea4...5ecf568. Read the comment docs.

@westonal westonal merged commit bc55182 into master Oct 8, 2017
@westonal westonal deleted the feature/french-word-list branch October 8, 2017 20:26
@nym-zone
Copy link
Copy Markdown

nym-zone commented Jan 5, 2018

Verification that this does not have a known bug: I hexdumped French.java, and verified that it does not contain the spurious BOM (U+FEFF) which is one of the subjects of BIP PR #622:

00000520  20 6e 65 77 20 53 74 72  69 6e 67 5b 5d 7b 0a 20  | new String[]{. |
00000530  20 20 20 20 20 20 20 20  20 20 20 22 61 62 61 69  |           "abai|
00000540  73 73 65 72 22 2c 0a 20  20 20 20 20 20 20 20 20  |sser",.         |

(I have not performed any other technical checks.)

@westonal
Copy link
Copy Markdown
Member Author

westonal commented Jan 5, 2018

@nym-zone Thanks! I appreciate you checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants