portable-net45+sl5+win8+wpa81+wp8 and xamarinmac20

[tofutim]

Please read the following information before posting the issue.

Details about Problem

NuGet product used (NuGet.exe | VS UI | Package Manager Console | dotnet.exe): Xamarin Studio

NuGet version (x.x.x.xxx): 3.5

OS version (i.e. win10 v1607 (14393.321)): OSX

Worked before? If so, with which NuGet version: 2

Detailed repro steps so we can see the same problem

(Hoping in here from https://forums.xamarin.com/discussion/comment/249677#Comment_249677)

1. Create a new Xamarin Mac Unified project

2. Try installing Microsoft.AspNet.SignalR.Client, it will fail because 'portable-net45+sl5+win8+wpa81+wp8' is not recognized as valid for xamarinmac20.

Retrieving package 'Microsoft.AspNet.SignalR.Client 2.2.1' from 'nuget.org'.
For adding package 'Microsoft.AspNet.SignalR.Client.2.2.1' to project 'Eggs' that targets 'xamarinmac20'.
Install failed. Rolling back...
Package 'Microsoft.AspNet.SignalR.Client.2.2.1' does not exist in project 'Eggs'
Package 'Microsoft.AspNet.SignalR.Client.2.2.1' does not exist in folder '/Users/tim/Projects/Eggs/packages'
Executing nuget actions took 147.87 ms
Could not install package 'Microsoft.AspNet.SignalR.Client 2.2.1'. You are trying to install this package into a project that targets 'Xamarin.Mac,Version=v2.0', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

The problem is apparently in https://github.com/NuGet/NuGet.Client/blob/4cccb13833ad29d6a0bcff055460d964f1b49cfe/src/NuGet.Core/NuGet.Frameworks/DefaultPortableFrameworkMappings.cs#L125-L130 where the Xamarin framework PCL compatibility is hardcoded. Here Xamarin Mac is missing and since Xamarin Studio uses nuget 3.x, sadness. Note that if a package targets netstandard1.1 it does work.

                    var monoandroid = new NuGetFramework(FrameworkConstants.FrameworkIdentifiers.MonoAndroid, new Version(0, 0));
                    var monotouch = new NuGetFramework(FrameworkConstants.FrameworkIdentifiers.MonoTouch, new Version(0, 0));
                    var xamarinIOs = new NuGetFramework(FrameworkConstants.FrameworkIdentifiers.XamarinIOs, new Version(0, 0));
                    var xamarinTVOS = new NuGetFramework(FrameworkConstants.FrameworkIdentifiers.XamarinTVOS, new Version(0, 0));
                    var xamarinWatchOS = new NuGetFramework(FrameworkConstants.FrameworkIdentifiers.XamarinWatchOS, new Version(0, 0));
                    var monoFrameworks = new NuGetFramework[] { monoandroid, monotouch, xamarinIOs, xamarinWatchOS, xamarinTVOS };

[mrward]

We should add the Xamarin.Mac framework to the optional framework list in DefaultPortableFrameworkMappings since we want to support adding PCLs into Xamarin.Mac mobile projects.

/cc @chamons

[emgarten]

@mrward would you be able to create a PR with the correct mappings?

Note that if a package targets netstandard1.1 it does work.

Long term netstandard will fix this. I see that the package contains netcore50 which may have been an attempt at this before the netstandard TFM was available.

[tofutim]

Looks like in https://github.com/NuGet/NuGet.Client/blob/4cccb13833ad29d6a0bcff055460d964f1b49cfe/src/NuGet.Core/NuGet.Frameworks/DefaultFrameworkMappings.cs there is already a FrameworkIdentifier for Mac

new KeyValuePair<string, string>(FrameworkConstants.FrameworkIdentifiers.XamarinMac, "xamarinmac"),

Not sure if it has to be xamarinmac20 or not.

[mrward]

I have opened a PR with the changes. I tested the new NuGet binaries with Xamarin Studio locally and this fixes the problem with Xamarin.Mac projects not allowing PCLs to be installed from NuGet packages.

[tofutim]

Oh you are awesome. I have a next nuget question for you. The SignalR portable library does not include WebSockets. WebSockets will be available in netstandard2.0 Xamarin iOS/Mac/tvOS/watchOS/Android support WebSockets, but it seems I would have to make a separate dll for each, is that the case? I also saw an Apple PCL but this does not seem fully baked yet and would exclude Android. Wish there was a xamarinstandardXX

…

On Wed, Feb 1, 2017 at 5:36 AM, Matt Ward ***@***.***> wrote: I have opened a PR <NuGet/NuGet.Client#1161> with the changes. I tested the new NuGet binaries with Xamarin Studio locally and this fixes the problem with Xamarin.Mac projects not allowing PCLs to be installed from NuGet packages. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4454 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJoRvkvbh35B0NSSbNJ8CoxSthJ8B4Rks5rYIpJgaJpZM4LzFYb> .

[mrward]

@tofutim - Yes if you cannot implement it in .NETStandard v1 nor in a PCL then you would need to have an assembly for each Xamarin platform you want to support.

[rrelyea]

set to rtm so we can triage and get approval for check into 4.0.0 if possible, otherwise will go in 4.0.1.

[joelverhagen]

@mrward, how does this relate to #2662? I put out a PR (NuGet/NuGet.Client#562) for that issue quite a while that never went in due to a rabbit-hole of discussions over email.

[joelverhagen]

The remaining Xamarin TFMs not in that list are:

MonoMac
XamarinPlayStation3
XamarinPlayStation4
XamarinPlayStationVita
XamarinXbox360
XamarinXboxOne

Does this seem right?

[mrward]

@joelverhagen - For #2662 the only impact would be just that we would want the XamarinMacNet target framework to allow PCLs to be installed. That PR is still valid.

MonoMac has never been used and there are no plans to use that target framework. The other target frameworks in that list are not currently being used as far as I am aware. They could be added to the list. Right now only Xamarin.Mac is in active use so it was the only one I added to the list.