Skip to content

Removing RID specific assets from compile#1103

Merged
emgarten merged 1 commit into
devfrom
dev-emgarten-compileRuntime
Mar 1, 2017
Merged

Removing RID specific assets from compile#1103
emgarten merged 1 commit into
devfrom
dev-emgarten-compileRuntime

Conversation

@emgarten
Copy link
Copy Markdown
Member

@emgarten emgarten commented Jan 6, 2017

This change removes RID specific assets in the runtimes/ folder from the compile section of the assets file.

When referencing a package that contained only runtimes/ assets it was possible to fallback to using these assets under compile.

Previous behavior:

  1. Select compile assets from ref/
  2. If no ref/ assets exist try lib/ and runtimes/ assets.

Fixed behavior:

  1. Select compile assets from ref/
  2. If no ref/ assets exist try lib/ assets.

Risk

Users depending directly on runtime only packages and not the ref package could see build breaks when the compile assets are missing. In this scenario it seems like users should just fix their references.

Fixes NuGet/Home#4207

//cc @ericstj @alpaix @rrelyea

@emgarten
Copy link
Copy Markdown
Member Author

emgarten commented Jan 6, 2017

//cc @joelverhagen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NuGet restore is selecting compile assets from runtime section.

3 participants