Get SDK resolver interactivity level from SdkResolverContext#2390
Conversation
|
/cc @Microsoft/msbuild-maintainers |
|
Okay I've updated to use our preview package, please review |
|
Another option would be to use reflection so I don't need to update the target framework and use a preview version of our package. |
|
Not sure what's the ask of this change and which VS branch is this targeting? Is this already approved for 15.9? Do we also need this for dev16? And who'd make sure to remove |
|
At the moment the credential plug-in will not prompt for login because we've hard coded the call to To take the change, I either need to compile against a newer version of the Yes this can get approved for 15.9 and the MSBuild change is already in. |
|
@jainaashish I've changed this to use reflection instead so its not touching as much. Please let me know when this can get into 15.9 as we need it ASAP to continue testing the authenticated feed scenarios |
|
as I said on another thread, we first need to merge it to dev and then release-4.9.0-preview2. Once we've substantial changes to be inserted into 15.9, we'll start with our insertion process (hopefully tomorrow or day after). |
|
Thanks, please merge when the CI completes |
|
Test signing failed for the last build. CI Build triggered again |
* Use reflection via an extension method to get the Interactive property * Improve readability
|
Merged into 4.9.0 with 814cc67 |
|
What's the Visual Studio default? |
|
The default is non-interactive. In Visual Studio, we're using a different credential provider at the moment. In dev16, the only way to set this property will be through a command-line argument to ensure its only set in a console window. |
Add an extension method that uses reflection to read the new property