Don't import reference assemblies for nestandard builds in NuGet.Configuration#4582
Merged
Merged
Conversation
jeffkl
approved these changes
Apr 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/1569
Regression? Last working version:
Description
Warnings are raised:
(ResolveAssemblyReferences target) ->
C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(2301,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Security". Check
to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [C:\Code\NuGet.Client\src\NuGet.Core\NuGet.Configuration\NuGet.Configuration.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(2301,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Xml". Check to m
ake sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [C:\Code\NuGet.Client\src\NuGet.Core\NuGet.Configuration\NuGet.Configuration.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(2301,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Xml.Linq". Check
to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [C:\Code\NuGet.Client\src\NuGet.Core\NuGet.Configuration\NuGet.Configuration.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(2301,5): warning MSB3243: No way to resolve conflict between "System.Xml, Version=4.0.0.0, Culture=neutral, Public
KeyToken=b77a5c561934e089" and "System.Xml". Choosing "System.Xml, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" arbitrarily. [C:\Code\NuGet.Client\src\NuGet.Core\NuGet.Configuration\NuGet.Configuration.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(2301,5): warning MSB3243: No way to resolve conflict between "System.Xml.Linq, Version=4.0.0.0, Culture=neutral, P
ublicKeyToken=b77a5c561934e089" and "System.Xml.Linq". Choosing "System.Xml.Linq, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" arbitrarily. [C:\Code\NuGet.Client\src\NuGet.Core\NuGet.Configuration\NuGet.Configurati
on.csproj]
This was mistakenly added in #4404 (comment)
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation