Skip to content

Pin Microsoft.Build and Microsoft.Extensions.CommandLineUtils.Sources versions for source-build#4643

Merged
dominoFire merged 1 commit into
NuGet:devfrom
MichaelSimons:version-pinning
Jun 2, 2022
Merged

Pin Microsoft.Build and Microsoft.Extensions.CommandLineUtils.Sources versions for source-build#4643
dominoFire merged 1 commit into
NuGet:devfrom
MichaelSimons:version-pinning

Conversation

@MichaelSimons
Copy link
Copy Markdown
Contributor

@MichaelSimons MichaelSimons commented May 24, 2022

Bug

Fixes: dotnet/source-build#2878

Regression: Caused by #4404

Description

This fix is needed so that the NuGet.Client build doesn't pickup the latest versions of these packages during source-build. Getting the latest version caused prebuilts and source-build breaks. This gets source-build to build NuGet.Client closer to the way the Microsoft build works.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@MichaelSimons MichaelSimons requested a review from a team as a code owner May 24, 2022 16:11
@ghost ghost added the Community PRs created by someone not in the NuGet team label May 24, 2022
@MichaelSimons
Copy link
Copy Markdown
Contributor Author

cc @crummel

@MichaelSimons
Copy link
Copy Markdown
Contributor Author

@nkolev92 and @zivkan - thanks for the quick reviews. FYI, I don't have access to merge. If you could, please merge when convenient. Thanks.

@nkolev92
Copy link
Copy Markdown
Member

It's usually on the Assignee to merge this cc @dominoFire

@dominoFire
Copy link
Copy Markdown
Contributor

Thank you for your contribution, @MichaelSimons !

@dominoFire dominoFire merged commit d970aa3 into NuGet:dev Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community PRs created by someone not in the NuGet team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backport NuGet.Client patch to pin package versions

5 participants