Prevent the initial pool bounds from being mutated #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecatcore
approved these changes
Jul 10, 2024
Member
thecatcore
left a comment
thecatcore
left a comment
There was a problem hiding this comment.
Awesome way to refactor and fix this code!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BlockBounds.ofBlockmethod will accept a mutable block position, which causes the first block position used to calculate block bounds to be ignored. This issue becomes apparent in the circle and donut map shapes, where the furthest water position will not be considered part of the pool.This pull request also includes miscellaneous changes that make implementing this fix easier.