Skip to content

Comments

[WIP] Fix test errors related to component link update#1

Merged
NullVoxPopuli merged 7 commits intopatch-2from
copilot/update-test-selectors
Feb 2, 2026
Merged

[WIP] Fix test errors related to component link update#1
NullVoxPopuli merged 7 commits intopatch-2from
copilot/update-test-selectors

Conversation

Copy link

Copilot AI commented Feb 2, 2026

  • Understand the test failures (6 tests in PackageVersions.spec.ts)
  • Identify the root cause: new external link added to component being picked up by test selectors
  • Update test selectors to exclude external links (those with target="_blank")
  • Merge fixes with latest changes from patch-2 branch
  • Apply filter changes to current test file version
  • Push changes to remote for CI verification
  • Request code review (completed - no issues found with test changes)
  • Complete task - tests should pass on CI now

Summary

Fixed 6 failing tests in PackageVersions.spec.ts by updating test selectors to exclude external links (with target="_blank"). The tests were broken after adding a community adoption distribution link to the Versions component. The fix ensures tests only select internal version links, not external links.

Original prompt

on the patch-2 branch, these test errors exist on CI https://github.com/npmx-dev/npmx.dev/actions/runs/21573561237/job/62156692468?pr=687

I added a link to a component, and I suspect the selectors in the test need to be updated as what I did normally should not have caused broken tests.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 5 commits February 2, 2026 00:59
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
@NullVoxPopuli NullVoxPopuli changed the base branch from main to patch-2 February 2, 2026 01:13
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review February 2, 2026 01:16
@NullVoxPopuli NullVoxPopuli merged commit 7feb8ad into patch-2 Feb 2, 2026
1 check was pending
Copilot AI requested a review from NullVoxPopuli February 2, 2026 01:16
Copilot stopped work on behalf of NullVoxPopuli due to an error February 2, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants