Skip to content

Add file extensions#19

Merged
rajatgoyal715 merged 17 commits intomasterfrom
add_file_extensions
Aug 4, 2019
Merged

Add file extensions#19
rajatgoyal715 merged 17 commits intomasterfrom
add_file_extensions

Conversation

@rishabhsingh971
Copy link
Member

@rishabhsingh971 rishabhsingh971 commented Aug 2, 2019

Closes #18

Changelog:

  • add file extension for programming language
  • add file extension for database language
  • handle differentiate languages with same extensions (e.g python2 and python3)

@rishabhsingh971 rishabhsingh971 added the enhancement New feature or request label Aug 2, 2019
@rishabhsingh971 rishabhsingh971 self-assigned this Aug 2, 2019
@rishabhsingh971 rishabhsingh971 removed the request for review from rajatgoyal715 August 3, 2019 10:11
Copy link
Member

@rajatgoyal715 rajatgoyal715 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have asked some questions, and have given some improvement suggestions.

@rajatgoyal715
Copy link
Member

Closes #18

Changelog:

  • add file extension for programming language
  • add file extension for database language
  • handle differentiate languages with same extensions (e.g python2 and python3)

Can you please explain the third point to me?

@rishabhsingh971
Copy link
Member Author

Closes #18
Changelog:

  • add file extension for programming language
  • add file extension for database language
  • handle differentiate languages with same extensions (e.g python2 and python3)

Can you please explain the third point to me?

Currently for the same problem if the solution is submitted in languages, whose extension is same, they all will have the same name. e.g if slug of the challenge is hello-world and solution is submitted in python3 as well as python2, name of the file generated for both language submission will be hello-world.py

@rishabhsingh971
Copy link
Member Author

Closes #18
Changelog:

  • add file extension for programming language
  • add file extension for database language
  • handle differentiate languages with same extensions (e.g python2 and python3)

Can you please explain the third point to me?

Currently for the same problem if the solution is submitted in languages, whose extension is same, they all will have the same name. e.g if slug of the challenge is hello-world and solution is submitted in python3 as well as python2, name of the file generated for both language submission will be hello-world.py

For now, I have added two flags to counter this problem:

  1. To make a separate folder for different languages e.g Hackerrank/Regex/Introduction/python3/matching.py and Hackerrank/Regex/Introduction/python/matching.py

  2. To prepend language in file extension e.g Hackerrank/Regex/Introduction/matching.python3.py and Hackerrank/Regex/Introduction/matching.python.py

They will be functional after #24.
Please suggest any other and/or better solution for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more file extensions

2 participants