fix error on login with outdated version in user-agent#45
Merged
rishabhsingh971 merged 1 commit intoNullifiers:masterfrom Oct 8, 2020
Merged
fix error on login with outdated version in user-agent#45rishabhsingh971 merged 1 commit intoNullifiers:masterfrom
rishabhsingh971 merged 1 commit intoNullifiers:masterfrom
Conversation
A long term fix would be to add the user-agent to the input params perhaps.
rishabhsingh971
approved these changes
Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long term fix would be to add the user-agent to the input params perhaps.
Related Issue
When using hsc there is an error when running .json() on the request. I tried running the request and found that the content showed an error related to the browser version.
Changes Proposed
Temporarily just update the user-agent string, long-term make a new parameter for it or add some library or service call to grab an up to date version.
Caveats
No, one liner.