Skip to content

Add dependabot#157

Closed
NobodyXu wants to merge 2 commits intoNullus157:prīmumfrom
NobodyXu:add-dependabot
Closed

Add dependabot#157
NobodyXu wants to merge 2 commits intoNullus157:prīmumfrom
NobodyXu:add-dependabot

Conversation

@NobodyXu
Copy link
Copy Markdown
Collaborator

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@Nemo157
Copy link
Copy Markdown
Member

Nemo157 commented Aug 29, 2022

In my experience dependabot is not useful for libraries, and results in a lot of overhead as it creates PR after PR (I see far too many repos on github with dozens of open dependabot PRs).

There is one thing I think could be useful in this space, being notified on new major versions of dependencies; but that doesn't appear to be something dependabot supports.

@NobodyXu
Copy link
Copy Markdown
Collaborator Author

I've used dependabot on other library crates such as openssh and it only generates a PR on new major ver of dependencies.

@Nemo157
Copy link
Copy Markdown
Member

Nemo157 commented Aug 30, 2022

Interesting, maybe they changed that behavior since merging into github.

Could you add rebase-strategy: "disabled" as the unnecessary rebasing it does doesn't work well with bors; then I'll give it a test.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Copy link
Copy Markdown
Collaborator Author

Interesting, maybe they changed that behavior since merging into github.

Could you add rebase-strategy: "disabled" as the unnecessary rebasing it does doesn't work well with bors; then I'll give it a test.

@Nemo157 Done!

@Nemo157
Copy link
Copy Markdown
Member

Nemo157 commented Aug 30, 2022

bors r+

bors Bot added a commit that referenced this pull request Aug 30, 2022
157: Add dependabot r=Nemo157 a=NobodyXu

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Co-authored-by: Jiahao XU <Jiahao_XU@outlook.com>
@bors bors Bot closed this Aug 30, 2022
@NobodyXu NobodyXu deleted the add-dependabot branch August 30, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants