Add support for archon mode. Make official APM the combined APM of each team#4
Open
manuelseeger wants to merge 4 commits intoNumberPigeon:mainfrom
Open
Add support for archon mode. Make official APM the combined APM of each team#4manuelseeger wants to merge 4 commits intoNumberPigeon:mainfrom
manuelseeger wants to merge 4 commits intoNumberPigeon:mainfrom
Conversation
…ch team. Also fixes a bug where IndexError is thrown but KeyError is caught when replay players > game meta data players.
for more information, see https://pre-commit.ci
Contributor
Author
|
Worker, SQ, stats trackers also likely assign the computed values wrongly since the event pids refer to the archon team, not the individual players. I only fixed APM tracker since that throws an exception on archon mode, while the other trackers run (if incomplete). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on my limited understanding of archon mode representation in replays based on the few examples I have.
Also fixes a bug where IndexError is thrown but KeyError is caught when replay players > game meta data players.