Skip to content

dts: nuvoton-npcm730-gsj: Update device tree to v9#24

Merged
maxdog988 merged 1 commit into
Nuvoton-Israel:Poleg-4.19.16-OpenBMCfrom
quanta-bmc:update_gsj_device_tree
Apr 16, 2019
Merged

dts: nuvoton-npcm730-gsj: Update device tree to v9#24
maxdog988 merged 1 commit into
Nuvoton-Israel:Poleg-4.19.16-OpenBMCfrom
quanta-bmc:update_gsj_device_tree

Conversation

@Fran-Hsu
Copy link
Copy Markdown

1.Add include file for flash layout.
2.Update the pinctrl file, remove the useless definitions.
3.Update the slave addr for smbus-13/14.

Signed-off-by: FranHsu Fran.Hsu@quantatw.com

1.Add include file for flash layout.
2.Update the pinctrl file, remove the useless definitions.
3.Update the slave addr for smbus-13/14.

Signed-off-by: FranHsu <Fran.Hsu@quantatw.com>
@Fran-Hsu Fran-Hsu changed the title dts: nuvoton-npcm730-gsj: dts: nuvoton-npcm730-gsj: Update device tree to v9 Apr 16, 2019
@maxdog988 maxdog988 merged this pull request into Nuvoton-Israel:Poleg-4.19.16-OpenBMC Apr 16, 2019
warp5tw pushed a commit to warp5tw/linux that referenced this pull request Mar 2, 2022
When bringing down the netdevice or system shutdown, a panic can be
triggered while accessing the sysfs path because the device is already
removed.

    [  755.549084] mlx5_core 0000:12:00.1: Shutdown was called
    [  756.404455] mlx5_core 0000:12:00.0: Shutdown was called
    ...
    [  757.937260] BUG: unable to handle kernel NULL pointer dereference at           (null)
    [  758.031397] IP: [<ffffffff8ee11acb>] dma_pool_alloc+0x1ab/0x280

    crash> bt
    ...
    PID: 12649  TASK: ffff8924108f2100  CPU: 1   COMMAND: "amsd"
    ...
     Nuvoton-Israel#9 [ffff89240e1a38b0] page_fault at ffffffff8f38c778
        [exception RIP: dma_pool_alloc+0x1ab]
        RIP: ffffffff8ee11acb  RSP: ffff89240e1a3968  RFLAGS: 00010046
        RAX: 0000000000000246  RBX: ffff89243d874100  RCX: 0000000000001000
        RDX: 0000000000000000  RSI: 0000000000000246  RDI: ffff89243d874090
        RBP: ffff89240e1a39c0   R8: 000000000001f080   R9: ffff8905ffc03c00
        R10: ffffffffc04680d4  R11: ffffffff8edde9fd  R12: 00000000000080d0
        R13: ffff89243d874090  R14: ffff89243d874080  R15: 0000000000000000
        ORIG_RAX: ffffffffffffffff  CS: 0010  SS: 0018
    Nuvoton-Israel#10 [ffff89240e1a39c8] mlx5_alloc_cmd_msg at ffffffffc04680f3 [mlx5_core]
    Nuvoton-Israel#11 [ffff89240e1a3a18] cmd_exec at ffffffffc046ad62 [mlx5_core]
    Nuvoton-Israel#12 [ffff89240e1a3ab8] mlx5_cmd_exec at ffffffffc046b4fb [mlx5_core]
    Nuvoton-Israel#13 [ffff89240e1a3ae8] mlx5_core_access_reg at ffffffffc0475434 [mlx5_core]
    Nuvoton-Israel#14 [ffff89240e1a3b40] mlx5e_get_fec_caps at ffffffffc04a7348 [mlx5_core]
    Nuvoton-Israel#15 [ffff89240e1a3bb0] get_fec_supported_advertised at ffffffffc04992bf [mlx5_core]
    Nuvoton-Israel#16 [ffff89240e1a3c08] mlx5e_get_link_ksettings at ffffffffc049ab36 [mlx5_core]
    Nuvoton-Israel#17 [ffff89240e1a3ce8] __ethtool_get_link_ksettings at ffffffff8f25db46
    Nuvoton-Israel#18 [ffff89240e1a3d48] speed_show at ffffffff8f277208
    Nuvoton-Israel#19 [ffff89240e1a3dd8] dev_attr_show at ffffffff8f0b70e3
    Nuvoton-Israel#20 [ffff89240e1a3df8] sysfs_kf_seq_show at ffffffff8eedbedf
    Nuvoton-Israel#21 [ffff89240e1a3e18] kernfs_seq_show at ffffffff8eeda596
    Nuvoton-Israel#22 [ffff89240e1a3e28] seq_read at ffffffff8ee76d10
    Nuvoton-Israel#23 [ffff89240e1a3e98] kernfs_fop_read at ffffffff8eedaef5
    Nuvoton-Israel#24 [ffff89240e1a3ed8] vfs_read at ffffffff8ee4e3ff
    Nuvoton-Israel#25 [ffff89240e1a3f08] sys_read at ffffffff8ee4f27f
    Nuvoton-Israel#26 [ffff89240e1a3f50] system_call_fastpath at ffffffff8f395f92

    crash> net_device.state ffff89443b0c0000
      state = 0x5  (__LINK_STATE_START| __LINK_STATE_NOCARRIER)

To prevent this scenario, we also make sure that the netdevice is present.

Signed-off-by: suresh kumar <suresh2514@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
warp5tw pushed a commit to warp5tw/linux that referenced this pull request May 10, 2022
When setting up a read or write to the OPB memory space, we must perform
five or six AHB writes. The ordering of these up until the trigger write
does not matter, so use writel_relaxed.

The generated code goes from (Debian GCC 10.2.1-6):

        mov     r8, r3
        mcr     15, 0, sl, cr7, cr10, {4}
        str     sl, [r6, Nuvoton-Israel#20]
        mcr     15, 0, sl, cr7, cr10, {4}
        str     r3, [r6, Nuvoton-Israel#24]
        mcr     15, 0, sl, cr7, cr10, {4}
        str     r1, [r6, Nuvoton-Israel#28]
        mcr     15, 0, sl, cr7, cr10, {4}
        str     r2, [r6, Nuvoton-Israel#32]
        mcr     15, 0, sl, cr7, cr10, {4}
        mov     r1, Nuvoton-Israel#1
        str     r1, [r6, Nuvoton-Israel#64]   ; 0x40
        mcr     15, 0, sl, cr7, cr10, {4}
        str     r1, [r6, Nuvoton-Israel#4]

to this:

        str     r3, [r7, Nuvoton-Israel#20]
        str     r2, [r7, Nuvoton-Israel#24]
        str     r1, [r7, Nuvoton-Israel#28]
        str     r3, [r7, Nuvoton-Israel#64]
        mov     r8, #0
        mcr     15, 0, r8, cr7, cr10, {4}
        str     r3, [r7, Nuvoton-Israel#4]

OpenBMC-Staging-Count: 1
Signed-off-by: Joel Stanley <joel@jms.id.au>
Acked-by: Jeremy Kerr <jk@ozlabs.org>
Reviewed-by: Eddie James <eajames@linux.ibm.com>
Tested-by: Eddie James <eajames@linux.ibm.com>
Link: https://lore.kernel.org/r/20210223041737.171274-1-joel@jms.id.au
Signed-off-by: Joel Stanley <joel@jms.id.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants