Jobs should move to failure if anything in library can't understand the posted job

[aultac]

If I post a job to a queue that doesn't match the schema, oada-jobs throws but the job never fails and is also not delivered to the service. If oada-jobs own internal code throws for any reason (like a malformed job resource) while handling a job object, it should fail the job overall and move to jobs-failure just as if the service threw on the job.

[abalmos]

I see what you mean. I'll add this to my todo list of later.

It's not clear to me that is a "failed" job ... rather it is simply a bug in the program that produced the job. Moving it to jobs-success and/or jobs-failure just breaks the formats there.

I could see one of two things:

1. A jobs-invalid list that has no formats defined and is really a programer debugging tool.
2. Just delete the invalid job(s) and rely on logs to tell you want happened -- the actual job resource would still be there and @oada/jobs could make a best effort attempt to fill in a results key with some sort of error.

I vote for 2

[aultac]

I think I’d prefer just #1: the job was supposed to happen and it didn’t (for whatever reason), so it’s an error/failure. Aaron

…

On May 12, 2020, at 1:50 PM, Andrew Balmos ***@***.***> wrote: I see what you mean. I'll add this to my todo list of later. It's not clear to me that is a "failed" job ... rather it is simply a bug in the program that produced the job. Moving it to jobs-success and/or jobs-failure just breaks the formats there. I could see one of two things: A jobs-invalid list that has no formats defined and is really a programer debugging tool. Just delete the invalid job(s) and rely on logs to tell you want happened -- the actual job resource would still be there and @oada/jobs could make a best effort attempt to fill in a results key with some sort of error. I vote for 2 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2KEUAVH2ZE542WQUTU573RRGD5FANCNFSM4M67GCZA>.