Skip to content

Use pinned version of MAINTAINERS.md per spec version #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lornajane merged 7 commits into from
May 14, 2024
Merged

Use pinned version of MAINTAINERS.md per spec version #3782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8eb1228
Quick-fix: use same pinned version of MAINTAINERS.md for all 3.x specs
ralfhandl May 6, 2024
2c1750a
Specific MAINTAINERS file per version
ralfhandl May 6, 2024
633e579
Use oldest MAINTAINERS for 3.0.0 and 3.0.1
ralfhandl May 6, 2024
16c549a
Recreate maintainers in 2015
ralfhandl May 6, 2024
40ef508
Update build.sh
ralfhandl May 6, 2024
f5988c3
Fine-tune maintainers
ralfhandl May 6, 2024
428d7d7
Emeritus is the last bullet list
ralfhandl May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions scripts/md2html/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,28 @@ mkdir -p deploy/js

cd scripts/md2html
mkdir -p history
git show c740e950d:MAINTAINERS.md > history/MAINTAINERS_v2.0.md
cat > history/MAINTAINERS_v2.0.md <<EOF
## Active
* Jeremy Whitlock [@whitlockjc](https://github.com/whitlockjc)
* Marsh Gardiner [@earth2marsh](https://github.com/earth2marsh)
Comment on lines +15 to +16
Copy link
Contributor Author

@ralfhandl ralfhandl May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whitlockjc @earth2marsh please confirm, my OpenAPI history knowledge is spotty.

Copy link
Member

@earth2marsh earth2marsh May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webron remains an active maintainer, too! otherwise lgtm (assuming I understood the question)

Copy link
Contributor Author

@ralfhandl ralfhandl May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @webron is an active maintainer in all versions of MAINTAINERS.md.

The question is whether I listed all active editors of version 2.0, and whether there were any changes between publication of 2.0 and 3.0.0.

* Ron Ratovsky [@webron](https://github.com/webron)
* Tony Tam [@fehguy](https://github.com/fehguy)
EOF
cp history/MAINTAINERS_v2.0.md history/MAINTAINERS_v3.0.0.md
git show c740e95:MAINTAINERS.md > history/MAINTAINERS_v3.0.1.md
git show 3140640:MAINTAINERS.md > history/MAINTAINERS_v3.0.2.md
cp history/MAINTAINERS_v3.0.2.md history/MAINTAINERS_v3.0.3.md
cp history/MAINTAINERS_v3.0.2.md history/MAINTAINERS_v3.1.0.md
# add lines for 3.0.4, 3.1.1, ...

cp -p js/* ../../deploy/js 2> /dev/null
cp -p markdown/* ../../deploy/ 2> /dev/null

node md2html.js --respec --maintainers ./history/MAINTAINERS_v2.0.md ../../versions/2.0.md > ../../deploy/oas/v2.0.html

latest=`git describe --abbrev=0 --tags`
latestCopied=none
for filename in ../../versions/[3456789].*.md ; do
for filename in ../../versions/[23456789].*.md ; do
version=$(basename "$filename" .md)
node md2html.js --respec --maintainers ../../MAINTAINERS.md ${filename} > ../../deploy/oas/v$version.html
node md2html.js --respec --maintainers ./history/MAINTAINERS_v$version.md ${filename} > ../../deploy/oas/v$version.html
if [ $version = $latest ]; then
if [[ ${version} != *"rc"* ]];then
# version is not a Release Candidate
Expand Down
3 changes: 2 additions & 1 deletion scripts/md2html/md2html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ function doMaintainers() {
let t = $(this).text().split('@')[0];
maintainers.push({name:t});
});
u = $('ul').eq(1);
if ($("ul").length < 2) return;
u = $("ul").last();
$(u).children('li').each(function(e){
let t = $(this).text().split('@')[0];
emeritus.push({name:t});
Expand Down