[new] scripts/update-schema-id #3790
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script updates the schema IDs in the following YAML files:
schemas/v{major}.{minor}/schema.yaml
schemas/v{major}.{minor}/schema-base.yaml
and generates the following JSON files from the updated YAML files:
schemas/v{major}.{minor}/schema.json
schemas/v{major}.{minor}/schema-base.json
notEthan
reviewed
May 12, 2024
scripts/update-schema-id
Outdated
| def error_exit(message) | ||
| $stderr.puts message | ||
| exit false | ||
| end |
Contributor
There was a problem hiding this comment.
built-in abort (method of Kernel) does the same as this error_exit method
Author
There was a problem hiding this comment.
@notEthan Thank you! I have replaced error_exit with abort.
Contributor
|
Thanks for getting us started with this change. We don't currently have any Ruby code in our repository, and it's not a skill present in our current maintainer cohort either. Could we discuss what this script does, and whether we can use a tech stack that is already in use? |
Author
|
Okay. A shell script version is here --> PR #3814 |
Member
|
Replaced by #3814 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script updates the schema IDs in the following YAML files:
and generates the following JSON files from the updated YAML files: