Skip to content

Conversation

@bizzappdev
Copy link

@bizzappdev bizzappdev commented Oct 8, 2025

Dependency PR for module brand: #270

sbejaoui and others added 30 commits October 3, 2025 17:31
[UPD] README.rst

[FIX] Fixed travis.
[UPD] Update analytic_brand.pot
Currently translated at 100.0% (2 of 2 strings)

Translation: brand-15.0/brand-15.0-analytic_brand
Translate-URL: https://translation.odoo-community.org/projects/brand-15-0/brand-15-0-analytic_brand/es/
Currently translated at 100.0% (2 of 2 strings)

Translation: brand-17.0/brand-17.0-analytic_brand
Translate-URL: https://translation.odoo-community.org/projects/brand-17-0/brand-17-0-analytic_brand/it/
There is a common issue in v18 when creating a new res.partner in tests
(which is the case here as we create a res.brand).
There is a required field autopost_bills in account addon.
As this addon doesn't depend on account, if we install this addon
on a DB where account is also installed, tests will fail because
the autopost_bills column is created into postgres, with the not null constraint,
but the default value won't be set by Odoo.

Running these tests in post-install ensure Odoo will set the default value
as specified in the account addon.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: brand-18.0/brand-18.0-analytic_brand
Translate-URL: https://translation.odoo-community.org/projects/brand-18-0/brand-18-0-analytic_brand/
@bizzappdev bizzappdev marked this pull request as ready for review October 8, 2025 14:29
@marielejeune
Copy link
Contributor

Hi,
Please note that I propose some refactoring in v18 (that could then be forward ported to v19). To me it is better to make use of standard account analytic distribution models instead of defining the analytic distribution on the brand and propagating it everywhere.
Check my PR here: #286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.