-
-
Notifications
You must be signed in to change notification settings - Fork 194
[19.0][MIG] product_brand #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… Thanks to NetAndCo who starts the module
* add smart button, move menu to a more visible position. * show brand in product.template kanban and tree views. * show brand in product variant kanban and tree views. * add product_brand kanban view. * update module's README and manifest file. * Search and group by brand for both product.product and product.template. * Convert model to new APIs. * Refactor products_count computation using product_ids one2many field. * Add public read access to product.brand (fixes 403 error on webshop for public user). * Make brand name required.
Migration to 10.0
Old form view was out of order: form blocks misaligned, because it was not using Odoo 10 views styling and layout.
Lookup fails when the ID is formatted. The unformatted version of the data is located under `raw_value`.
Currently translated at 100,0% (21 of 21 strings) Translation: product-attribute-11.0/product-attribute-11.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-11-0/product-attribute-11-0-product_brand/de/
… with other odoo apps. (#364) * Make the logo always the same width (64px). * Remove the description (200 first caracters). Not relevant for a configuration model. * Move the brand name and product count beside the image. This is the way it is displayed in partners and products kanban views.
Currently translated at 100.0% (24 of 24 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/es/
Currently translated at 37.5% (9 of 24 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nb_NO/
Currently translated at 100.0% (24 of 24 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nb_NO/
Currently translated at 100.0% (24 of 24 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nl_NL/
Co-authored-by: Do Anh Duy <duyda@trobz.com>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: brand-18.0/brand-18.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/brand-18-0/brand-18-0-product_brand/
Currently translated at 100.0% (22 of 22 strings) Translation: brand-18.0/brand-18.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/brand-18-0/brand-18-0-product_brand/it/
Currently translated at 95.4% (21 of 22 strings) Translation: brand-18.0/brand-18.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/brand-18-0/brand-18-0-product_brand/nl/
sale_ok and purchase_ok fields are not well aligned after product_brand is installed. This fix re-align the two fields in the same base line.
salehi2001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the code and it was correct.
kamyar2099
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code tested and ok
moemoonsun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test code and work correctly.
|
This PR has the |
nicolascol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM functional review
@pedrobaeza Could you merge please?
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 83274bc. Thanks a lot for contributing to OCA. ❤️ |
[MIG] change _compute_products_count function and test