Skip to content

Conversation

@adelghaedi
Copy link

[MIG] change _compute_products_count function and test

bguillot and others added 30 commits October 15, 2025 14:25
* add smart button, move menu to a more visible position.
* show brand in product.template kanban and tree views.
* show brand in product variant kanban and tree views.
* add product_brand kanban view.
* update module's README and manifest file.
* Search and group by brand for both product.product and product.template.
* Convert model to new APIs.
* Refactor products_count computation using product_ids one2many field.
* Add public read access to product.brand (fixes 403 error on webshop for public user).
* Make brand name required.
Old form view was out of order: form blocks misaligned, because it was
not using Odoo 10 views styling and layout.
Lookup fails when the ID is formatted. The unformatted version of the
data is located under `raw_value`.
Currently translated at 100,0% (21 of 21 strings)

Translation: product-attribute-11.0/product-attribute-11.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-11-0/product-attribute-11-0-product_brand/de/
… with other odoo apps. (#364)

* Make the logo always the same width (64px).
* Remove the description (200 first caracters). Not relevant for a configuration model.
* Move the brand name and product count beside the image. This is the way it is displayed in partners and products kanban views.
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/es/
Currently translated at 37.5% (9 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nb_NO/
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nb_NO/
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nl_NL/
lef-adhoc and others added 13 commits October 15, 2025 14:25
Co-authored-by: Do Anh Duy <duyda@trobz.com>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: brand-18.0/brand-18.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/brand-18-0/brand-18-0-product_brand/
Currently translated at 100.0% (22 of 22 strings)

Translation: brand-18.0/brand-18.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/brand-18-0/brand-18-0-product_brand/it/
Currently translated at 95.4% (21 of 22 strings)

Translation: brand-18.0/brand-18.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/brand-18-0/brand-18-0-product_brand/nl/
sale_ok and purchase_ok fields are not well aligned after product_brand is installed. This fix re-align the two fields in the same base line.
Copy link

@salehi2001 salehi2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the code and it was correct.

Copy link

@kamyar2099 kamyar2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code tested and ok

Copy link

@moemoonsun moemoonsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test code and work correctly.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@nicolascol nicolascol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functional review
@pedrobaeza Could you merge please?

@pedrobaeza pedrobaeza changed the title 19.0 mig product brand [19.0][MIG] product_brand Nov 13, 2025
@pedrobaeza
Copy link
Member

/ocabot merge nobump
/ocabot migration product_brand

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-275-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Nov 13, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 13, 2025
18 tasks
@OCA-git-bot OCA-git-bot merged commit 30cf2fb into OCA:19.0 Nov 13, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 83274bc. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.