[18.0][IMP] contract: Add index on account.move old_contract_id

[qgroulard]

This field is often searched which may be slow on DB with a lot of account moves.

[flotho]

Code review,
LGTM
Great thanks

[FrancoMaxime]

lgtm

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[pedrobaeza]

There's only one search:

contract/contract/models/contract.py

Line 426 in 1df7f34

invoices |= self.env["account.move"].search([("old_contract_id", "=", self.id)])

and that one is only for retro-compatibility with 11-. I'm wondering if we should still provide that compatibility...

[qgroulard]

There's only one search:

contract/contract/models/contract.py

Line 426 in 1df7f34

invoices |= self.env["account.move"].search([("old_contract_id", "=", self.id)])

and that one is only for retro-compatibility with 11-. I'm wondering if we should still provide that compatibility...

I agree we should consider removing this feature.

[pedrobaeza]

Go ahead then.

[pedrobaeza]

The field hasn't been removed as talked.

[qgroulard]

That's still on my todo list but the go-live of a major customer in a few days leaves me little time.