[18.0][MIG] website_sale_suggest_create_account: Migration to 18.0 #1051

cem-adhoc · 2025-05-12T14:55:22Z

No description provided.

pilarvargas-tecnativa · 2025-05-15T17:11:19Z

Please reduce administrative commits

pilarvargas-tecnativa · 2025-05-15T17:13:43Z

website_sale_suggest_create_account/static/tests/tours/checkout.esm.js

@@ -0,0 +1,47 @@
+/** @odoo-module */


Suggested change

/** @odoo-module */

Not necessary in v18

OCA Transbot updated translations from Transifex

Example of module which requires such refactoring: https://github.com/it-projects-llc/website-addons/tree/10.0/website_sale_checkout_store [FIX] condition to show normal checkout button was wrong in website_sale_suggest_create_account I was equal to (user_authenticated or not signup_allowed and can_checkout) while it has to be (user_authenticated or not signup_allowed) and can_checkout

Added translation using Weblate (German)

Always show 'Process Checkout', not highlighted if user not logged in Suggest to login or signup, according to 'invitation_scope', avoiding too many buttons in cart page Added translation using Weblate (Catalan) Translated using Weblate (Spanish) Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_suggest_create_account Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_suggest_create_account/es/

Ensure that 'vat' is not empty for compatibility with website_sale_vat_required module Added translation using Weblate (Dutch)

…ests

…with `Environment.manage()` website_sale_suggest_create_account 15.0.1.0.1

TT44387

[BOT] post-merge updates

- Create setUpClass method - Include context keys for avoiding mail operations overhead. [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-16.0/e-commerce-16.0-website_sale_suggest_create_account Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_suggest_create_account/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-16.0/e-commerce-16.0-website_sale_suggest_create_account Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_suggest_create_account/ Translated using Weblate (Spanish) Currently translated at 100.0% (5 of 5 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_suggest_create_account Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_suggest_create_account/es/

…solve conflict between 'website_sale_suggest_create_account' and 'website_sale_checkout_skip_payment' This commit addresses a conflict between the 'website_sale_suggest_create_account' and 'website_sale_checkout_skip_payment' modules. When 'website_sale_suggest_create_account' is installed, it modifies a section of the view by removing a class. Subsequently, upon installing the 'website_sale_checkout_skip_payment' module, it expects to find this class, resulting in an error due to the previous deletion. By adjusting the priority of the view, this commit ensures that the necessary class is retained during positioning, resolving the conflict. [BOT] post-merge updates Translated using Weblate (Italian) Currently translated at 100.0% (5 of 5 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_suggest_create_account Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_suggest_create_account/it/

[BOT] post-merge updates

- steps must be a function - no more require("web_tour.tour") [BOT] post-merge updates Added translation using Weblate (Spanish (Venezuela))

cem-adhoc · 2025-05-23T17:53:16Z

@pilarvargas-tecnativa done. Can you review it?

pilarvargas-tecnativa · 2025-05-26T05:55:02Z

website_sale_suggest_create_account/tests/test_shop_buy.py

+        if self.env["ir.module.module"]._get("payment_custom").state != "installed":
+            self.skipTest("Transfer provider is not installed")
+        transfer_provider = self.env.ref("payment.payment_provider_transfer")
+        transfer_provider.write(
+            {
+                "state": "enabled",
+                "is_published": True,
+            }
+        )
+        transfer_provider._transfer_ensure_pending_msg_is_set()


Suggested change

if self.env["ir.module.module"]._get("payment_custom").state != "installed":

self.skipTest("Transfer provider is not installed")

transfer_provider = self.env.ref("payment.payment_provider_transfer")

transfer_provider.write(

{

"state": "enabled",

"is_published": True,

}

)

transfer_provider._transfer_ensure_pending_msg_is_set()

This should not be included in the test, as it creates an unnecessary dependency. Testing this functionality does not require reaching the payment process. Furthermore, it may mask errors in the test or functionality by skipping the test when the payment provider is not installed. The tour has some outdated steps, but it likely isn't failing due to this block in the test.

pilarvargas-tecnativa · 2025-05-26T05:58:17Z

website_sale_suggest_create_account/static/tests/tours/checkout.esm.js

+    steps: () => [
+        // Shop Page
+        {
+            trigger: "a:contains('Customizable')",


Suggested change

trigger: "a:contains('Customizable')",

trigger: "a:contains('Customizable')",

run: "click",

This is not failing because of the above. In many steps the action is missing.

pilarvargas-tecnativa · 2025-05-26T05:59:44Z

website_sale_suggest_create_account/static/tests/tours/checkout.esm.js

+        // Cart page
+        {
+            trigger:
+                "a.btn-primary[href='/web/login?redirect=/shop/checkout?express=1']",


This step is looking for something that does not exist.

pilarvargas-tecnativa

thanks!

pilarvargas-tecnativa · 2025-05-28T06:52:48Z

@Tecnativa TT54397
@CarlosRoca13 please take a look

CarlosRoca13

Thanks!

pedrobaeza · 2025-05-28T08:43:27Z

/ocabot migration website_sale_suggest_create_account
/ocabot merge nobump

OCA-git-bot · 2025-05-28T08:43:34Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1051-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2025-05-28T08:52:20Z

Congratulations, your PR was merged at 3ddcb84. Thanks a lot for contributing to OCA. ❤️

cvinh · 2025-10-05T17:25:16Z

Hello

AFAICS Suggesting to create an account is already in v18 Core

This module does it differently but I think it should be mentionned in the README

Best regards

[MIG] website_sale_suggest_create_account: Migration to 10.0 (OCA#172)

57a17b3

pilarvargas-tecnativa reviewed May 15, 2025

View reviewed changes

pedrobaeza and others added 20 commits May 23, 2025 17:04

Update __manifest__.py

5e99630

OCA Transbot updated translations from Transifex

[MIG] website_sale_suggest_create_account: basic migration v10 to v11

29979e5

Added translation using Weblate (German)

porting website_sale_suggest_create_account to 12.0

fe9b9bb

[MIG] website_sale_suggested_create_account: Migration to 13.0

1c17f73

[IMP] website_sale_suggest_create_account: unit test compatibility

bebd6fa

Ensure that 'vat' is not empty for compatibility with website_sale_vat_required module Added translation using Weblate (Dutch)

[IMP] Update dotfiles + switch to GH actions

09f23b5

[MIG] website_sale_suggest_create_account: Migration to 15.0

ab5a428

[FIX] website_sale_suggest_create_account: Recover and fix original t…

a153de7

…ests

[IMP] website_sale_suggest_create_account: Avoid deprecation warning …

d268ce3

…with `Environment.manage()` website_sale_suggest_create_account 15.0.1.0.1

[MIG] website_sale_suggest_create_account: Migration to version 16.0

79be94b

TT44387

[UPD] Update website_sale_suggest_create_account.pot

37daae3

[BOT] post-merge updates

[IMP] website_sale_suggest_create_account: pre-commit execution

83f9b16

[MIG] website_sale_suggest_create_account: Migration to 17.0

119773c

[UPD] Update website_sale_suggest_create_account.pot

9c5615e

[BOT] post-merge updates

[FIX] website_sale_suggest_create_account: migrate test to V17

f8e99d1

- steps must be a function - no more require("web_tour.tour") [BOT] post-merge updates Added translation using Weblate (Spanish (Venezuela))

[IMP] website_sale_suggest_create_account: pre-commit execution

1e6ef30

cem-adhoc force-pushed the 18.0-mig-website_sale_suggest_create_account branch 2 times, most recently from 7ca578c to facd219 Compare May 23, 2025 17:07

pilarvargas-tecnativa reviewed May 26, 2025

View reviewed changes

cem-adhoc force-pushed the 18.0-mig-website_sale_suggest_create_account branch from facd219 to d6fcdc2 Compare May 27, 2025 23:51

[MIG] website_sale_suggest_create_account: Migration to 18.0

becc496

cem-adhoc force-pushed the 18.0-mig-website_sale_suggest_create_account branch from d6fcdc2 to becc496 Compare May 27, 2025 23:54

pilarvargas-tecnativa approved these changes May 28, 2025

View reviewed changes

CarlosRoca13 approved these changes May 28, 2025

View reviewed changes

OCA-git-bot added the approved label May 28, 2025

OCA-git-bot added this to the 18.0 milestone May 28, 2025

OCA-git-bot added the bot is merging ⏳ label May 28, 2025

OCA-git-bot mentioned this pull request May 28, 2025

Migration to version 18.0 #974

Open

40 tasks

OCA-git-bot merged commit 676b5d4 into OCA:18.0 May 28, 2025
6 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 28, 2025

	trigger: "a:contains('Customizable')",
	trigger: "a:contains('Customizable')",
	run: "click",

Uh oh!

[18.0][MIG] website_sale_suggest_create_account: Migration to 18.0 #1051

[18.0][MIG] website_sale_suggest_create_account: Migration to 18.0 #1051

Uh oh!

Conversation

cem-adhoc commented May 12, 2025

Uh oh!

pilarvargas-tecnativa commented May 15, 2025

Uh oh!

pilarvargas-tecnativa May 15, 2025

Choose a reason for hiding this comment

Uh oh!

cem-adhoc commented May 23, 2025

Uh oh!

pilarvargas-tecnativa May 26, 2025

Choose a reason for hiding this comment

Uh oh!

pilarvargas-tecnativa May 26, 2025

Choose a reason for hiding this comment

Uh oh!

pilarvargas-tecnativa May 26, 2025

Choose a reason for hiding this comment

Uh oh!

pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

pilarvargas-tecnativa commented May 28, 2025

Uh oh!

CarlosRoca13 left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented May 28, 2025

Uh oh!

OCA-git-bot commented May 28, 2025

Uh oh!

Uh oh!

OCA-git-bot commented May 28, 2025

Uh oh!

cvinh commented Oct 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants