[18.0] [MIG] website_sale_comparison_hide_price: Migration to 18.0

[kobros-tech]

No description provided.

[kobros-tech]

[mide-dynapps]

any chance to have a fix ?

[kobros-tech]

any chance to have a fix ?

Do you mean test cases?

[mide-dynapps]

regarding the checks failed. Is it possible to push a fix ?

[kobros-tech]

regarding the checks failed. Is it possible to push a fix ?

yes, I put it in my schedule.

[xaviedoanhduy]

Thanks for the work. I have a suggestion that we should hide this compare price display too.

[xaviedoanhduy]

fyi, this is the new product compare layout without website_sale_comparison_hide_price module.

[kobros-tech]

@xaviedoanhduy

it is a good idea to hide comparison field, should be merged in older versions too!

[xaviedoanhduy]

LGTM

[pilarvargas-tecnativa]

Please rebase

[kobros-tech]

@pilarvargas-tecnativa

Is OK?

[pilarvargas-tecnativa]

I have the next error:

Odoo Server Error

RPC_ERROR
Odoo Server Error

Occured on oca-e-commerce-18-0-pr1057-d67550184927.runboat.odoo-community.org on 2025-11-25 15:06:49 GMT

Traceback (most recent call last):
  File "<2015>", line 253, in template_2015
  File "<2015>", line 121, in template_2015_content
  File "/opt/odoo/odoo/addons/base/models/ir_qweb.py", line 2483, in _get_widget
    content = converter.value_to_html(value, field_options)
  File "/opt/odoo/odoo/addons/base/models/ir_qweb_fields.py", line 479, in value_to_html
    raise ValueError(_("The value send to monetary field is not a number."))
ValueError: The value send to monetary field is not a number.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/odoo/odoo/http.py", line 2166, in _transactioning
    return service_model.retrying(func, env=self.env)
  File "/opt/odoo/odoo/service/model.py", line 156, in retrying
    result = func()
  File "/opt/odoo/odoo/http.py", line 2133, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/opt/odoo/odoo/http.py", line 2381, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 333, in _dispatch
    result = endpoint(**request.params)
  File "/opt/odoo/odoo/http.py", line 754, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/odoo/addons/website_sale_comparison/controllers/main.py", line 42, in get_product_data
    'render': request.env['ir.ui.view']._render_template(
  File "/opt/odoo/addons/website/models/ir_ui_view.py", line 453, in _render_template
    return super()._render_template(template, values=values)
  File "/opt/odoo/odoo/addons/base/models/ir_ui_view.py", line 2218, in _render_template
    return self.env['ir.qweb']._render(template, values)
  File "/opt/odoo/odoo/tools/profiler.py", line 313, in _tracked_method_render
    return method_render(self, template, values, **options)
  File "/opt/odoo/odoo/addons/base/models/ir_qweb.py", line 611, in _render
    result = ''.join(rendering)
  File "<2015>", line 261, in template_2015
odoo.addons.base.models.ir_qweb.QWebException: Error while render the template
ValueError: The value send to monetary field is not a number.
Template: website_sale_comparison.product_product
Path: /t/div/div[2]/h6/div[1]/del[1]
Node: <del t-if="&#10;                website.website_show_price and not product.website_hide_price&#10;            " t-attf-class="text-muted me-1 h6 mb-0 small" style="white-space: nowrap;" t-esc="combination_info[\'compare_list_price\']" t-options="{\'widget\': \'monetary\', \'display_currency\': website.currency_id}"/>

The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
    RPC_ERROR
        at makeErrorFromResponse (http://oca-e-commerce-18-0-pr1057-d67550184927.runboat.odoo-community.org/web/assets/1/7f05d9f/web.assets_frontend_lazy.min.js:4533:165)
        at XMLHttpRequest.<anonymous> (http://oca-e-commerce-18-0-pr1057-d67550184927.runboat.odoo-community.org/web/assets/1/7f05d9f/web.assets_frontend_lazy.min.js:4538:13)

In a clean database, I install the module that is being migrated and contacts. When I enter /shop, that error appears without configuring anything.

[kobros-tech]

@pilarvargas-tecnativa

The error is interesting, can you add the very same steps that I can follow to reproduce the bug?

If I can reproduce the error I can introduce the solution.

In OCA boat I cannot see the bug.

[pilarvargas-tecnativa]

@pilarvargas-tecnativa

The error is interesting, can you add the very same steps that I can follow to reproduce the bug?

If I can reproduce the error I can introduce the solution.

In OCA boat I cannot see the bug.

In a clean database, I install this module only. I log in as admin and, without configuring anything at all, I access /shop and add a product to the comparison tool, and then the error occurs.

[pilarvargas-tecnativa]

http://oca-e-commerce-18-0-pr1057-d67550184927.runboat.odoo-community.org/shop

[kobros-tech]

I see it now

[pilarvargas-tecnativa]

I see it now

Thank you, I'll wait for the fix to review again.

[kobros-tech]

@pilarvargas-tecnativa

I hope this one is ok

[pilarvargas-tecnativa]

LGTM 👍

Thanks!

@Tecnativa TT57284

@juancarlosonate-tecnativa please take a look!

[pedrobaeza]

/ocabot migration website_sale_comparison_hide_price

Let's merge it with the two existing approvals

/ocabot merge nobump

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1057-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at f15838e. Thanks a lot for contributing to OCA. ❤️