Skip to content

Conversation

@jbaudoux
Copy link

@jbaudoux jbaudoux commented Jun 24, 2025

  • Allow to manage the list of products from the ecommerce category
  • Add filter by eCommerce category on the products list

@jbaudoux jbaudoux force-pushed the 18-add-product_public_category_product branch 3 times, most recently from c27d33e to 4087c99 Compare June 24, 2025 09:18
@jbaudoux jbaudoux force-pushed the 18-add-product_public_category_product branch from 4087c99 to 1ba91b3 Compare June 24, 2025 09:26
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 26, 2025
@github-actions github-actions bot closed this Nov 30, 2025
@jbaudoux
Copy link
Author

@OCA/e-commerce-maintainers Can you reopen and merge if there is no objection?

@pedrobaeza pedrobaeza added this to the 18.0 milestone Dec 1, 2025
@pedrobaeza pedrobaeza reopened this Dec 1, 2025
@pedrobaeza
Copy link
Member

I think public from the module name is useless and make it longer, as you are already saying website_sale, don't you think?

@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 1, 2025
@jbaudoux
Copy link
Author

jbaudoux commented Dec 1, 2025

I think public from the module name is useless and make it longer, as you are already saying website_sale, don't you think?

Thanks for the review. I like to be explicit and prevent any confusion as category and public category are 2 different things.

@pedrobaeza
Copy link
Member

But you are repeating 2 times product and the module purpose is not very explicit. If you want that, I would remove then website_sale...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants