[18.0][MIG] website_sale_require_legal: Migration to version 18.0 #1110

eduezerouali-tecnativa · 2025-09-05T14:46:03Z

cc @Tecnativa TT57525
ping @pilarvargas-tecnativa @pedrobaeza

…cope This is what the module does now: - Add the posibility to configure legal terms acceptance requirement before saving a new partner. - Log that acceptance as a note in the partner. - Extend upstream's legal requirement before payment and log that acceptance as a note in the sale order. @Tecnativa TT25963

Currently translated at 100.0% (1 of 1 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_require_legal/es/

TT38355

…page TT41842 The dependency on website_legal_page has been removed because it has been merged into account

Currently translated at 100.0% (3 of 3 strings) Translation: e-commerce-15.0/e-commerce-15.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_require_legal/es/

TT45248

…e_vat_required module TT44388

Currently translated at 100.0% (3 of 3 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_require_legal/it/

TT51564

pilarvargas-tecnativa · 2025-09-05T15:21:27Z

website_sale_require_legal/i18n/hr.po

+#~ msgid "Confirm"
+#~ msgstr "Potvrdi"


Suggested change

#~ msgid "Confirm"

#~ msgstr "Potvrdi"

website_sale_require_legal/i18n/es.po

pedrobaeza · 2025-09-08T09:42:05Z

/ocabot migration website_sale_require_legal

alexmorel-tecnativa

I performed a functional test, and its allows me save the address without confirming the terms and conditions checkbox.

From Edit Address, I entered the editor and enabled the following:
- Require Legal Terms Acceptance
- Accept Terms & Conditions
Edited the address and did not check the box of:
- I agree to the terms & conditions
Clicked the button: Save Address

And the address was saved without giving any error.

There is onother issue, when you create a new address, it doesn't get saved, it just keeps loading:

Test.Terms.webm

pilarvargas-tecnativa · 2025-09-19T08:06:52Z

Please check CI

website_sale_require_legal/controllers/main.py

eduezerouali-tecnativa · 2025-10-16T13:03:59Z

@pedrobaeza @alexmorel-tecnativa could you review please?

alexmorel-tecnativa · 2025-10-16T15:45:08Z

Thanks! @eduezerouali-tecnativa,
I performed a functional and everything is now working correctly ✅.

It dosen't allow saveing the address without confirming the terms and conditions checkbox.
When editing an address and not accepting the Terms and Conditions, it properly shows the error:
“You must accept the Terms and Conditions to continue.”
When creating a new address, it correctly requires confirmation of the Terms and Conditions.

pedrobaeza · 2025-10-16T15:56:39Z

/ocabot merge nobump

OCA-git-bot · 2025-10-16T15:56:48Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1110-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2025-10-16T16:07:15Z

Congratulations, your PR was merged at b9942f2. Thanks a lot for contributing to OCA. ❤️

yajo and others added 24 commits September 5, 2025 05:41

[ADD] website_sale_require_legal

5f464f6

[9.0] [MIG] website_sale_require_legal module

587d2c0

[MIG][website_sale_require_legal] Migrate to v10

c03bc7e

website_sale_require_legal: Fix rendering error when error list is empty

ea470b4

[IMP] record metadata on registration and acceptance of conditions

58bda43

[MIG] website_sale_require_legal: Migration to 11.0

fad7808

[12.0][MIG] website_sale_require_legal: Migration to v12

94eb9e0

[FIX] website_sale_require_legal: Turn tour green

ed437ab

[FIX] website_sale_require_legal: Tour Test

0d7fb71

Added translation using Weblate (Finnish)

d890638

[MIG] website_sale_require_legal: Migration to 13.0

9a746e5

Translated using Weblate (Spanish)

c7dc18a

Currently translated at 100.0% (1 of 1 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_require_legal/es/

[MIG] website_sale_require_legal: Migration to 14.0

65a7bb9

[MIG] website_sale_require_legal: Migration to version 15.0

9ef9366

TT38355

[FIX] website_sale_require_legal: tests

3a70dd4

[FIX] website_sale_require_legal: remove dependency to website_legal_…

f27921d

…page TT41842 The dependency on website_legal_page has been removed because it has been merged into account

Translated using Weblate (Spanish)

e0158ac

Currently translated at 100.0% (3 of 3 strings) Translation: e-commerce-15.0/e-commerce-15.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_require_legal/es/

[MIG] website_sale_require_legal: Migration to version 16.0

d3281ec

TT45248

[FIX] website_sale_require_legal: Test compatibility with website_sal…

934dbcf

…e_vat_required module TT44388

Translated using Weblate (Italian)

32e952a

Currently translated at 100.0% (3 of 3 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_require_legal/it/

[IMP] website_sale_require_legal: pre-commit auto fixes

a95a85b

[MIG] website_sale_require_legal: Migration to version 17.0

a7e20c8

TT51564

[IMP] website_sale_require_legal: pre-commit auto fixes

cc3193c

pilarvargas-tecnativa reviewed Sep 5, 2025

View reviewed changes

website_sale_require_legal/i18n/es.po Outdated Show resolved Hide resolved

eduezerouali-tecnativa force-pushed the 18.0-mig-website_sale_require_legal branch from b22a99b to a96fc66 Compare September 8, 2025 06:11

OCA-git-bot added this to the 18.0 milestone Sep 8, 2025

OCA-git-bot mentioned this pull request Sep 8, 2025

Migration to version 18.0 #974

Open

40 tasks

eduezerouali-tecnativa force-pushed the 18.0-mig-website_sale_require_legal branch from a96fc66 to cc3825a Compare September 8, 2025 11:02

eduezerouali-tecnativa requested a review from pilarvargas-tecnativa September 8, 2025 11:12

alexmorel-tecnativa reviewed Sep 9, 2025

View reviewed changes

eduezerouali-tecnativa force-pushed the 18.0-mig-website_sale_require_legal branch 2 times, most recently from a55131b to 7c098e3 Compare September 10, 2025 09:44

eduezerouali-tecnativa requested a review from alexmorel-tecnativa September 15, 2025 17:13

eduezerouali-tecnativa force-pushed the 18.0-mig-website_sale_require_legal branch from 7c098e3 to edc12ee Compare September 19, 2025 07:25

pilarvargas-tecnativa approved these changes Sep 19, 2025

View reviewed changes

eduezerouali-tecnativa force-pushed the 18.0-mig-website_sale_require_legal branch 2 times, most recently from 978fe47 to 36bf063 Compare September 19, 2025 09:46

pilarvargas-tecnativa reviewed Oct 1, 2025

View reviewed changes

website_sale_require_legal/controllers/main.py Outdated Show resolved Hide resolved

pilarvargas-tecnativa reviewed Oct 1, 2025

View reviewed changes

website_sale_require_legal/controllers/main.py Outdated Show resolved Hide resolved

pilarvargas-tecnativa reviewed Oct 1, 2025

View reviewed changes

website_sale_require_legal/controllers/main.py Outdated Show resolved Hide resolved

eduezerouali-tecnativa force-pushed the 18.0-mig-website_sale_require_legal branch from 36bf063 to 10a1c74 Compare October 1, 2025 14:46

[MIG] website_sale_require_legal: Migration to 18.0

06759f9

eduezerouali-tecnativa force-pushed the 18.0-mig-website_sale_require_legal branch from 10a1c74 to 06759f9 Compare October 1, 2025 14:56

alexmorel-tecnativa approved these changes Oct 16, 2025

View reviewed changes

OCA-git-bot added the approved label Oct 16, 2025

OCA-git-bot added the bot is merging ⏳ label Oct 16, 2025

OCA-git-bot merged commit a13c3a0 into OCA:18.0 Oct 16, 2025
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 16, 2025

pedrobaeza deleted the 18.0-mig-website_sale_require_legal branch October 16, 2025 16:09

Uh oh!

[18.0][MIG] website_sale_require_legal: Migration to version 18.0 #1110

[18.0][MIG] website_sale_require_legal: Migration to version 18.0 #1110

Uh oh!

Conversation

eduezerouali-tecnativa commented Sep 5, 2025

Uh oh!

pilarvargas-tecnativa Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pedrobaeza commented Sep 8, 2025

Uh oh!

alexmorel-tecnativa left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pilarvargas-tecnativa commented Sep 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eduezerouali-tecnativa commented Oct 16, 2025

Uh oh!

alexmorel-tecnativa commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Oct 16, 2025

Uh oh!

OCA-git-bot commented Oct 16, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

alexmorel-tecnativa left a comment •

edited

Loading

alexmorel-tecnativa commented Oct 16, 2025 •

edited

Loading