[18.0][MIG] website_sale_charge_payment_fee: Migration to version 18.0 #1123

eduezerouali-tecnativa · 2025-10-22T13:25:39Z

cc @Tecnativa TT58475
ping @pilarvargas-tecnativa @carlos-lopez-tecnativa

Migrated from #1047

Supersedes #1047

ADD website_sale_charge_payment_fee_delivery: link module ADD website_sale_charge_payment_fee_quote: link module

…o acquirer If there are no acquirers, gets ``` Error to render compiling AST TypeError: 'NoneType' object has no attribute '__getitem__' Template: 929 Path: /templates/t/t/div/div[1]/div/div[2]/input Node: <input type="hidden" t-att-value="selected_acquirer.id if selected_acquirer else acquirers[0].id" name="selected_acquirer_id" data-oe-id="1278" data-oe-xpath="/data/xpath[3]/input" data-oe-model="ir.ui.view" data-oe-field="arch"/> ```

…re is no acquirer

…re no acquirers

We avoid this way the warning on runbot and it's more tolerant to inheritance.

Currently translated at 100.0% (21 of 21 strings) Translation: e-commerce-14.0/e-commerce-14.0-website_sale_charge_payment_fee Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_charge_payment_fee/es/

pilarvargas-tecnativa · 2025-10-29T12:35:36Z

website_sale_charge_payment_fee/tests/test_website_sale_fee.py

+        with RecordCapturer(self.env["sale.order"], []) as capture:
+            self.start_tour("/shop", "payment_fee_tour", login="portal", step_delay=100)
+        created_order = capture.records
+        price = 10 / 100 * 99.0


Why does this value change?

It does not change the value, actually is calculate the expected value of created_order.amount_payment_fee. That's why next step it and assetEqual.

I mean, why does the calculation change? Before, it was done with price = 10 / 100 * 49.5

change demo price form 14.0 to 18.0
16.5 * 3 = 49.5 and 33 * 3 = 99

Could you avoid depending on demo data to prevent external changes from altering the behavior here?

carlos-lopez-tecnativa · 2025-10-29T14:17:14Z

website_sale_charge_payment_fee/models/sale_order.py

+        res = super()._compute_website_order_line()
+        website_order_line = self.env["sale.order.line"]
+        for order in self:
+            for line in order.website_order_line:
+                if not line.payment_fee_line:
+                    website_order_line |= line
+            order.website_order_line = website_order_line
+        return res


Why change this code? I think the older code is clearer and more compact.

carlos-lopez-tecnativa · 2025-10-29T14:21:14Z

website_sale_charge_payment_fee/tests/test_website_sale_fee.py

+                "is_published": True,
+            }
+        )
+        transfer_provider._compute_charge_fee_description()


You don’t need the _compute_charge_fee_description function; it should be called automatically.

carlos-lopez-tecnativa · 2025-10-29T14:28:25Z

website_sale_charge_payment_fee/models/sale_order.py

+            amount_payment_fee = 0.0
+            if (
+                self.env["website"]
+                .get_current_website()
+                .show_line_subtotals_tax_selection
+                == "tax_excluded"
+            ):
+                for line in order.order_line:
+                    if line.payment_fee_line:
+                        amount_payment_fee += line.price_subtotal
+            else:
+                for line in order.order_line:
+                    if line.payment_fee_line:
+                        amount_payment_fee += line.price_total


The same here: Why change this code? I think the older code is clearer and more compact.

carlos-lopez-tecnativa · 2025-10-29T15:02:37Z

website_sale_charge_payment_fee/static/src/js/website_sale_fee.esm.js

+            browser.location.href =
+                "/shop/payment?provider_id=" +
+                providerId +
+                "&payment_option_id=" +
+                paymentOptionId;
+        }


I see that this redirect reloads the page, and I get this message when switching between different payment providers. Is this correct? I can’t continue from this step.

I attached a video. I believe the problem occurs when you have two or more payment providers. In this case, I installed Demo and Wire Transfer and selected the second payment option. The window flickers, and internally the sale order changes when another payment method is selected. So, I think the window is not being refreshed correctly.

website_sale_charge_payment_fee.mp4

@carlos-lopez-tecnativa @eduezerouali-tecnativa we added this function in the migration to resolve the problem, could you add and test, thanks:
_prepareTransactionRouteParams() {
const transactionRouteParams = this._super(...arguments);
// eslint-disable-next-line no-undef
const cartValueEl = document.querySelector(".oe_currency_value");
const cartValue = cartValueEl?.textContent || "0";
transactionRouteParams.amount = Number(cartValue);
return transactionRouteParams;
},

@Alexgars73 That problem was already solve or you are talking about express checkout?

@eduezerouali-tecnativa i'm getting the same error that @carlos-lopez-tecnativa mentioned "The cart has been updated. Please refresh the page".

@Alexgars73 try on runboat, it is working fine.

eduezerouali-tecnativa · 2025-10-29T16:54:14Z

@carlos-lopez-tecnativa thanks for your review! changes you requested done. Couldn't replicate what your error. Could you give more details about that?

carlos-lopez-tecnativa · 2025-10-29T18:36:58Z

website_sale_charge_payment_fee/models/sale_order.py

                order.amount_payment_fee = sum(
-                    order.order_line.filtered("payment_fee_line").mapped("price_total")
+                    order.order_line.filtered("payment_fee_line").mapped(
+                        "price_subtotal"


Why price_subtotal??

It should be price_total

carlos-lopez-tecnativa · 2025-10-29T18:41:32Z

website_sale_charge_payment_fee/models/payment_provider.py

+    charge_fee_description = fields.Text(
+        "Fee Description", compute="_compute_charge_fee_description"
    )
+    charge_fee_product_id = fields.Many2one("product.product", string="Fee Product")


I think this product should have a domain that allows selecting only records of type service. What do you think?

I agree with you. Makes sense, as I can't see a possible scenario where that fee could be a good

carlos-lopez-tecnativa · 2025-10-29T18:47:34Z

website_sale_charge_payment_fee/static/src/js/website_sale_fee.esm.js

+            browser.location.href =
+                "/shop/payment?provider_id=" +
+                providerId +
+                "&payment_option_id=" +
+                paymentOptionId;
+        }


I attached a video. I believe the problem occurs when you have two or more payment providers. In this case, I installed Demo and Wire Transfer and selected the second payment option. The window flickers, and internally the sale order changes when another payment method is selected. So, I think the window is not being refreshed correctly.

website_sale_charge_payment_fee.mp4

carlos-lopez-tecnativa

Working fine, just a doubt about the class change. I just want to understand the change. Other than that, LGTM.

carlos-lopez-tecnativa · 2025-10-31T12:55:50Z

website_sale_charge_payment_fee/tests/test_website_sale_fee.py

+        with RecordCapturer(self.env["sale.order"], []) as capture:
+            self.start_tour("/shop", "payment_fee_tour", login="portal", step_delay=100)
+        created_order = capture.records
+        price = 10 / 100 * 99.0


Could you avoid depending on demo data to prevent external changes from altering the behavior here?

carlos-lopez-tecnativa · 2025-10-31T12:59:07Z

website_sale_charge_payment_fee/controllers/main.py

+    @http.route(
+        "/shop/payment", type="http", auth="public", website=True, sitemap=False
+    )
+    def shop_payment(self, **post):


This class PaymentPortal, doesn’t have the shop_payment function in the payment module. This method is added in the website_sale module. Why did you change the class to inherit from it instead of inheriting from the WebsiteSale class?

eduezerouali-tecnativa · 2025-11-04T10:58:27Z

@carlos-lopez-tecnativa Changes done, no it does not depends on demo data for test.

Reyes4711-S73 · 2025-11-04T15:54:59Z

@eduezerouali-tecnativa I tested and it is not working well when you try to pay directly with X payment.

If you press the button pay with demo, it doesn't apply the fee charge.

Otherwise, if you continue with the checkout and you fill all the billing addres and shipping address, the fee is charged.

carlos-lopez-tecnativa · 2025-11-05T13:37:07Z

website_sale_charge_payment_fee/views/payment_provider_views.xml

+        <field name="inherit_id" ref="payment.payment_provider_form" />
+        <field name="arch" type="xml">
+            <xpath expr="//notebook" position="inside">
+                <page string="Charge payment fee">


@eduezerouali-tecnativa I tested and it is not working well when you try to pay directly with X payment.

@Reyes4711-S73 The case you mean is when the payment provider supports express checkout, but in this case, it’s out of scope for this module.
@eduezerouali-tecnativa You can add it to the ROADMAP and hide the page in this case.
I don’t know which payment providers support express checkout apart from Demo, which is never used in the real world.

Suggested change

<page string="Charge payment fee">

<page string="Charge payment fee" invisible="allow_express_checkout">

I implemented your suggestions, anyways i think that stripe used it too. Also add it to roadmap. Thanks :)

carlos-lopez-tecnativa · 2025-11-05T13:37:30Z

website_sale_charge_payment_fee/tests/test_website_sale_fee.py

+        )
+        cls.product_product_optional = cls.env["product.template"].create(
+            {
+                "name": "Oprional",


Suggested change

"name": "Oprional",

"name": "Optional",

carlos-lopez-tecnativa · 2025-11-05T13:38:04Z

website_sale_charge_payment_fee/tests/test_website_sale_fee.py

+                "is_published": True,
+                "sale_ok": True,
+                "taxes_id": [Command.clear()],
+                "optional_product_ids": [Command.set(cls.product_product_optional.ids)],


Is the optional product really necessary? Why?

not really necessary, i did that,just to not adjust the tour. Anyways i did adjust the tour. :)

carlos-lopez-tecnativa

LGTM

pedrobaeza · 2025-11-05T14:36:04Z

/ocabot migration website_sale_charge_payment_fee

eduezerouali-tecnativa · 2025-12-02T09:58:33Z

@pilarvargas-tecnativa please could you review

eLBati and others added 17 commits October 22, 2025 13:22

ADD website_sale_charge_payment_fee

d6e8727

ADD website_sale_charge_payment_fee_delivery: link module ADD website_sale_charge_payment_fee_quote: link module

fixup! [FIX] website_sale_charge_payment_fee: Do not blow up when the…

aba19b5

…re is no acquirer

[FIX] website_sale_charge_payment_fee: Use a browse record if there a…

30e6665

…re no acquirers

[12.0][MIG] website_sale_charge_payment_fee: Migration to 12.0

cb71d5c

[IMP] Adjust coding style

061341f

[IMP] Imrpove javascript

005ab90

[IMP] Adjust Pay Now button javascript, remove tax

032e696

[IMP] Fix save_token pattern, adjust fee display

b81b248

[IMP] Adjust update_fee_line, add comment

072b809

[IMP] Add currency to fix price field, update pot

7c68f5a

[IMP] Fix required error on charge_fee_currency_id

2576225

[FIX] website_sale_charge_payment_fee: Use hasclass in xpath expression

038c3d5

We avoid this way the warning on runbot and it's more tolerant to inheritance.

[IMP] website_sale_charge_payment_fee: black, isort, prettier

7668d66

[MIG] website_sale_charge_payment_fee: Migration to 14.0

137e9f5

[IMP] website_sale_charge_payment_fee: pre-commit auto fixes

d7385fc

eduezerouali-tecnativa mentioned this pull request Oct 22, 2025

[18.0][MIG] website_sale_charge_payment_fee: migration to 18.0 #1047

Open

eduezerouali-tecnativa force-pushed the 18.0-mig-website_sale_charge_payment_fee branch 3 times, most recently from b4062d4 to 541f2ef Compare October 22, 2025 14:26

pilarvargas-tecnativa reviewed Oct 29, 2025

View reviewed changes

carlos-lopez-tecnativa suggested changes Oct 29, 2025

View reviewed changes

eduezerouali-tecnativa force-pushed the 18.0-mig-website_sale_charge_payment_fee branch 3 times, most recently from e9cb772 to 1d1663f Compare October 29, 2025 16:51

carlos-lopez-tecnativa suggested changes Oct 29, 2025

View reviewed changes

eduezerouali-tecnativa force-pushed the 18.0-mig-website_sale_charge_payment_fee branch from 1d1663f to b1edf83 Compare October 31, 2025 11:33

eduezerouali-tecnativa requested a review from pilarvargas-tecnativa October 31, 2025 11:39

eduezerouali-tecnativa requested a review from carlos-lopez-tecnativa October 31, 2025 11:39

carlos-lopez-tecnativa reviewed Oct 31, 2025

View reviewed changes

eduezerouali-tecnativa force-pushed the 18.0-mig-website_sale_charge_payment_fee branch from b1edf83 to b9e382d Compare November 4, 2025 10:57

eduezerouali-tecnativa requested a review from carlos-lopez-tecnativa November 4, 2025 10:58

eduezerouali-tecnativa force-pushed the 18.0-mig-website_sale_charge_payment_fee branch from b9e382d to d20d908 Compare November 4, 2025 11:40

carlos-lopez-tecnativa reviewed Nov 5, 2025

View reviewed changes

[MIG] website_sale_charge_payment_fee: Migration to 18.0

9c7ddf1

eduezerouali-tecnativa force-pushed the 18.0-mig-website_sale_charge_payment_fee branch from d20d908 to 9c7ddf1 Compare November 5, 2025 14:04

carlos-lopez-tecnativa approved these changes Nov 5, 2025

View reviewed changes

OCA-git-bot added this to the 18.0 milestone Nov 5, 2025

OCA-git-bot mentioned this pull request Nov 5, 2025

Migration to version 18.0 #974

Open

40 tasks

	<page string="Charge payment fee">
	<page string="Charge payment fee" invisible="allow_express_checkout">

Uh oh!

[18.0][MIG] website_sale_charge_payment_fee: Migration to version 18.0 #1123

Are you sure you want to change the base?

[18.0][MIG] website_sale_charge_payment_fee: Migration to version 18.0 #1123

Uh oh!

Conversation

eduezerouali-tecnativa commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eduezerouali-tecnativa Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eduezerouali-tecnativa commented Oct 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eduezerouali-tecnativa commented Nov 4, 2025

Uh oh!

Reyes4711-S73 commented Nov 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eduezerouali-tecnativa Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Nov 5, 2025

Uh oh!

eduezerouali-tecnativa commented Dec 2, 2025

eduezerouali-tecnativa commented Oct 22, 2025 •

edited

Loading

eduezerouali-tecnativa Oct 29, 2025 •

edited

Loading

eduezerouali-tecnativa Nov 5, 2025 •

edited

Loading