[18.0][MIG] website_sale_tax_toggle: Migration to version 18.0 #1125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tour was not effective because: - Steps did not have proper wait conditions. - That made them run fast without actually testing the desired effect. - That left many remaining requests that could made tests to fail randomly, as you can see in OCA#420 (comment). Now it's shorter but more effective: - It skips going to `/shop` at the start because it starts already there. - It moves tour code to demo data. - It adds proper checks to each trigger, to make sure it doesn't run before checking the result is OK. @Tecnativa TT24410
…2x_alt_price @Tecnativa TT24410
- Switch to setUpClass for avoiding repeat the same setup for each test. - Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (2 of 2 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_tax_toggle Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_tax_toggle/it/
…t website level Implemented a new setting `default_tax_toggle` at the website level to control the default state of the tax toggle on the website. This allows the tax toggle to be set to active or inactive by default when a user first visits the website. TT55895
Currently translated at 100.0% (5 of 5 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_tax_toggle Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_tax_toggle/it/
…play taxes for the entire website. TT55895
Currently translated at 100.0% (6 of 6 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_tax_toggle Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_tax_toggle/it/
Contributor
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
LGTM, please let me know what you think about my comments.
pilarvargas-tecnativa
force-pushed
the
18.0-mig-website_sale_tax_toggle
branch
2 times, most recently
from
76345ac to
b702d2f
Compare
Member
|
/ocabot migration website_sale_tax_toggle |
pilarvargas-tecnativa
force-pushed
the
18.0-mig-website_sale_tax_toggle
branch
2 times, most recently
from
69768f9 to
4e08fb5
Compare
carlos-lopez-tecnativa
suggested changes
Oct 29, 2025
Comment on lines
1
to
5
| A default value is set to show taxes at website level. To set this | ||
| value, go to website \> configuration and select the website on which to | ||
| change the default value. The field Toggle default tax will be unchecked | ||
| by default, to make the default value active when entering the website, | ||
| check the field. |
Contributor
There was a problem hiding this comment.
I think it’s necessary to update the README
pilarvargas-tecnativa
force-pushed
the
18.0-mig-website_sale_tax_toggle
branch
from
4e08fb5 to
17c3c99
Compare
carlos-lopez-tecnativa
approved these changes
Oct 29, 2025
Contributor
Author
|
@CarlosRoca13 please review |
Member
|
/ocabot merge nobump |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 31719b9. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa TT54398
@carlos-lopez-tecnativa please review