[18.0][MIG] website_sale_acquirer_confirm_order: Migration to version 18.0 #1127
Conversation
| <field name="inherit_id" ref="payment.payment_provider_form" /> | ||
| <field name="arch" type="xml"> | ||
| <field name="allow_express_checkout" position="after"> | ||
| <field name="confirm_order" /> |
There was a problem hiding this comment.
Functionally tested and working, but I think a CONTEXT.md file is necessary to explain in which cases this module can be used.
Every module payment_**** that adds the option to pay on the website and integrates with external providers must be in charge of handling when the transaction is approved, declined, or canceled. So, the common case is that these modules, in any way, end up confirming the order.
Therefore, the only module I can see that could use this one is when using a Wire Transfer. If that’s the case, this field should be visible only in those cases.
There was a problem hiding this comment.
done, thanks!
|
/ocabot migration website_sale_acquirer_confirm_order |
pilarvargas-tecnativa
force-pushed
the
18.0-mig-website_sale_acquirer_confirm_order
branch
from
db8a4b4 to
b23604b
Compare
pilarvargas-tecnativa
force-pushed
the
18.0-mig-website_sale_acquirer_confirm_order
branch
from
b23604b to
06ba374
Compare
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
Wait, when I use a payment link, the order is not confirmed, it just stays in the Sent state. Please review this case.
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
Wait, when I use a payment link, the order is not confirmed, it just stays in the Sent state. Please review this case.
According to the internal chat, this module is intended for e-commerce, and a sales order from the backend is out of scope for this module. So, LGTM.
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 0a27201. Thanks a lot for contributing to OCA. ❤️ |
5 participants
Migrated from #1084
@Tecnativa TT58470
@carlos-lopez-tecnativa @victoralmau please review