[10.0][IMP] migrated sale_require_login and dependency

[ovnicraft]

Module from 9.0 is working ok, migrate to 10.0 without major changes

[oca-clabot]

Hey @ovnicraft, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

• Cristian Salamea (no github login found)

Appreciation of efforts,
OCA CLAbot

[pedrobaeza]

There's already a PR for this module. Please review #138 and maybe propose any change to that branch.

[ovnicraft]

@pedrobaeza the migration hasta latest commit Nov/2016 this is an issue :(. So if there is no response about this, OCA has any definition about close the abandon PR and continues with another proposed by community ?

[pedrobaeza]

Well, not exactly a procedure, but when someone doesn't respond in the PR, usual steps is to take over his/her work and create another PR. Continuing from the previous PR work or start from the scratch will depend on the complexity of the changes. Anyway, I see that this module depends on another one, so you should first migrate that one also, isn't it?

[ovnicraft]

@pedrobaeza I migrate both in this PR, so i review their changes and has the same changes (module works without major changes).

Open a new PR for dependency module?

[pedrobaeza]

Let's see if tomorrow there's an answer, and if not, please open first a PR for the dependency, and then we reuse this one for the website_sale_require_login.

[ovnicraft]

Ok 👍

[iledarn]

@pedrobaeza I would like you to take this instead of mine #138, since @ovnicraft has fixed what was not right and so much time has elapsed . Sorry I'm messing up

[yelizariev]

Seems like @yajo's review are not taken into account. At least two obvious requests (move assets.xml to demo and runbot link) are not done