Skip to content

Conversation

@arantxa-s73
Copy link
Contributor

@arantxa-s73 arantxa-s73 commented Jul 9, 2024

Description

This PR migrates the module website_sale_stock_provisioning_date from Odoo version 16.0 to 17.0, ensuring compatibility with the latest version of Odoo and adopting improvements introduced in the API and module structure.

Key Changes

  • The free_qty field has been added to utilize the _get_product_available_qty method within _get_combination_info. This ensures that the stock obtained accurately reflects what is actively being used on the website.
  • Existing tests have been updated to align with the recent changes.
  • A new test has been added specifically for the free_qty field to validate its functionality.

@arantxa-s73 arantxa-s73 changed the title 17.0][MIG] website_sale_stock_provisioning_date: Migration to 17.0 [17.0][MIG] website_sale_stock_provisioning_date: Migration to 17.0 Jul 9, 2024
@miguel-S73 miguel-S73 force-pushed the 17.0-mig-website_sale_stock_provisioning_date branch from a33befe to 7f9f9c2 Compare August 9, 2024 09:04
Ernesto Tejeda and others added 8 commits October 25, 2024 09:09
Show the future provisioning date closest to the current date
for a product in the eCommerce.
The provisioning date was always showing in the same format without
respecting the date format defined in the language settings.

It is added in function `_get_combination_info` instead of in function
`_get_next_provisioning_date` so that the date is still formatted even
if function `_get_next_provisioning_date` is inherited.
@miguel-S73 miguel-S73 force-pushed the 17.0-mig-website_sale_stock_provisioning_date branch 5 times, most recently from 0be5ece to 3702320 Compare October 28, 2024 11:37
@miguel-S73
Copy link
Contributor

@pedrobaeza all checks green.
Please, Can you review this changes?

@pedrobaeza
Copy link
Member

Right now we are not needing this module in 17, but I tag it and it can be reviewed by others.

/ocabot migration website_sale_stock_provisioning_date

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 28, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 28, 2024
38 tasks
@github-actions
Copy link

github-actions bot commented Mar 2, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 2, 2025
@arantxa-s73
Copy link
Contributor Author

@pedrobaeza Can you put the tag "no stale" to prevent the pr from closing, please

@pedrobaeza
Copy link
Member

@arantxa-s73 please rebase for having a running runboat, and review it for getting this merged.

@arantxa-s73 arantxa-s73 force-pushed the 17.0-mig-website_sale_stock_provisioning_date branch from 3702320 to c24526f Compare March 3, 2025 09:07
@arantxa-s73
Copy link
Contributor Author

@pedrobaeza ready

@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 3, 2025
@pedrobaeza
Copy link
Member

One of your team may review it.

@pilarvargas-tecnativa
Copy link
Contributor

Please reduce administrative commits

oca-ci and others added 2 commits May 13, 2025 14:59
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_stock_provisioning_date
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_stock_provisioning_date/
@arantxa-s73 arantxa-s73 force-pushed the 17.0-mig-website_sale_stock_provisioning_date branch from c24526f to c353037 Compare May 13, 2025 13:00
@arantxa-s73 arantxa-s73 reopened this May 13, 2025
@arantxa-s73
Copy link
Contributor Author

@pilarvargas-tecnativa done

Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

@Tecnativa TT54700

@carlos-lopez-tecnativa can you take a look?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-949-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5d27588 into OCA:17.0 May 15, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4604ce9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants