[16.0][IMP] website_sale_product_assortment #975

Pablocce · 2024-10-15T10:03:31Z

Description:

When more than one assortment is applied to the customer on e-commerce, the functionality doesn't work correctly, and the configurations are not applied properly, for example, when combining "no restriction" with "no show" or "no purchase."

This PR is essential for the functionality of this module because the products are not shown or cannot be bought when they should.

Cases covered with this improvement:

Assortment A with product 1 and configuration "Avoid to show non available products" and assortment B with product 2 and configuration "Avoid to show non available products". Before, both products were displayed with the label "Not available". With this PR both products are displayed and they are allowed to be purchased.
Assorment A with product 1 and configuration "Avoid to show non available products" and assortment B with product 2 and configuration "No restrictions". Before, only the products from de assortment A were displayed, restricting the products from de B assortment. With this PR, the restrictions are not applied to the assortments with the configuration "No restrictions" when simultaneous assortments are applied to the same client or website.

Solution:
To resolve this problem, we have made the following modifications:

The method that returns the products to display is adjusted so that, in the absence of restrictive stock, it correctly returns the values.
Additionally, the method that returns the products and their restrictions is adjusted to make the assortments compatible.

OCA-git-bot · 2024-10-15T10:03:38Z

Hi @CarlosRoca13,
some modules you are maintaining are being modified, check this out!

pedrobaeza · 2024-11-04T07:16:18Z

website_sale_product_assortment/controllers/website_sale.py

+        no_restriction_assortments = any(
+            assortment.website_availability == "no_show" for assortment in assortments
+        )
+


Please remove extra empty lines inside a method.

Done! Thanks for the correction

CarlosRoca13

Thank you so much! please remove all the extra empty lines

CarlosRoca13 · 2024-11-07T12:14:44Z

website_sale_product_assortment/controllers/website_sale.py

+        )
        assortment_restriction = False
        allowed_product_ids = set()
+


Suggested change

CarlosRoca13 · 2024-11-07T12:14:58Z

website_sale_product_assortment/controllers/website_sale.py

+
+        if not no_restriction_assortments:
+            return allowed_product_ids, assortment_restriction
+


Suggested change

CarlosRoca13 · 2024-11-07T12:17:59Z

website_sale_product_assortment/models/product_template.py

        )
-        assortment_dict = {}
+        partner_assortments = self.env["ir.filters"].sudo()
+


Suggested change

CarlosRoca13 · 2024-11-07T12:18:10Z

website_sale_product_assortment/models/product_template.py

+                if assortment.website_availability != "no_restriction":
+                    partner_assortments |= assortment
+                allowed_product_ids.update(assortment.all_product_ids.ids)
+


Suggested change

CarlosRoca13 · 2024-11-07T12:36:12Z

And if you can, add a test to check that is working OK on future migrations 😄

CarlosRoca13

Thanks! 😄

CarlosRoca13 · 2024-11-08T15:24:39Z

Ups! the whitespaces still there...

… products * Methods that calculate product availability based on e-commerce assortments are being corrected to make them compatible.

CarlosRoca13

👍

Pablocce · 2024-11-08T15:27:49Z

Ups! the whitespaces still there...

Done! I was doing the rebase, thanks!

OCA-git-bot · 2024-11-08T15:36:41Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Pablocce · 2024-12-31T09:06:47Z

Is something missing @CarlosRoca13 to merge this?

Thanks!

pedrobaeza

/ocabot merge patch

OCA-git-bot · 2024-12-31T09:09:30Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-975-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot · 2024-12-31T09:15:00Z

Congratulations, your PR was merged at e016f16. Thanks a lot for contributing to OCA. ❤️

Pablocce force-pushed the 16.0-imp-website_sale_product_assortment branch 5 times, most recently from ef4cf6f to f58223c Compare October 20, 2024 21:47

Pablocce marked this pull request as ready for review October 28, 2024 08:52

Pablocce force-pushed the 16.0-imp-website_sale_product_assortment branch from 3fb2022 to a249a20 Compare October 28, 2024 08:55

danielduqma approved these changes Nov 3, 2024

View reviewed changes

pedrobaeza added this to the 16.0 milestone Nov 4, 2024

pedrobaeza requested a review from CarlosRoca13 November 4, 2024 07:16

pedrobaeza reviewed Nov 4, 2024

View reviewed changes

CarlosRoca13 reviewed Nov 7, 2024

View reviewed changes

Pablocce force-pushed the 16.0-imp-website_sale_product_assortment branch 2 times, most recently from 2abb8e5 to 60bc3f6 Compare November 8, 2024 15:01

CarlosRoca13 approved these changes Nov 8, 2024

View reviewed changes

OCA-git-bot added the approved label Nov 8, 2024

Pablocce force-pushed the 16.0-imp-website_sale_product_assortment branch from 60bc3f6 to a60663d Compare November 8, 2024 15:26

[FIX] website_sale_product_assortment: dont restrict other assortment…

efbb7a1

… products * Methods that calculate product availability based on e-commerce assortments are being corrected to make them compatible.

Pablocce force-pushed the 16.0-imp-website_sale_product_assortment branch from a60663d to efbb7a1 Compare November 8, 2024 15:26

CarlosRoca13 approved these changes Nov 8, 2024

View reviewed changes

OCA-git-bot added the ready to merge label Nov 8, 2024

pedrobaeza changed the title ~~[IMP] website_sale_product_assortment~~ [16.0][IMP] website_sale_product_assortment Dec 31, 2024

pedrobaeza reviewed Dec 31, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Dec 31, 2024

OCA-git-bot merged commit bcc8b92 into OCA:16.0 Dec 31, 2024
2 of 3 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 31, 2024

pilarvargas-tecnativa mentioned this pull request Oct 17, 2025

[18.0][MIG] website_sale_product_assortment: Migration to 18.0 #1120

Open


		if not no_restriction_assortments:
		return allowed_product_ids, assortment_restriction

Uh oh!

[16.0][IMP] website_sale_product_assortment #975

[16.0][IMP] website_sale_product_assortment #975

Uh oh!

Conversation

Pablocce commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OCA-git-bot commented Oct 15, 2024

Uh oh!

pedrobaeza Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

Pablocce Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

CarlosRoca13 left a comment

Choose a reason for hiding this comment

Uh oh!

CarlosRoca13 Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

CarlosRoca13 Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

CarlosRoca13 Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

CarlosRoca13 Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

CarlosRoca13 commented Nov 7, 2024

Uh oh!

CarlosRoca13 left a comment

Choose a reason for hiding this comment

Uh oh!

CarlosRoca13 commented Nov 8, 2024

Uh oh!

CarlosRoca13 left a comment

Choose a reason for hiding this comment

Uh oh!

Pablocce commented Nov 8, 2024

Uh oh!

OCA-git-bot commented Nov 8, 2024

Uh oh!

Pablocce commented Dec 31, 2024

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Dec 31, 2024

Uh oh!

OCA-git-bot commented Dec 31, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Pablocce commented Oct 15, 2024 •

edited

Loading