[15.0] [MIG+REF / RFC] event_session: Migration to 15.0
#275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename 'date' to 'date_begin' for being homogeneous with event fields * Split tests * Remove 'start_time' and 'end_time' as no needed * Convert hours to UTC for avoiding timezone issues
- Fix tz in calculated name - Fix tests - Add event sessions count to reports - Fixes computing update of stored value - Fixes views and reports - Fixes generator not creating last day sessions - Totalizations in session tree view - Security config - Adds es_ES translations - Fixes seats limits on sessions
- Fix report query - Adds progress bar to sessions tree view - Improves tests - Fixes seats limit check
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-12.0/event-12.0-event_session Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-event_session/
The big issue with this kind of code is that if you have a user with a certain locale being used, it will override the locale system wide and the next request on the server may have the dates formatted with strftime in a different language than expected... The other issue is that some systems do not provide a set of actual locales so on a server running in docker without manually modifying a dockerfile to install a set of locales, it may fail to switch the locale to a non existing one. It will just fail to compute the field. Babel is already a dependency of odoo and it's a bit strange to not use it. Get the locale the same way ir.qweb.fields do This commit use the same method as ir.qweb.fields to get the locale to use to translate a date. The previous code didn't took into account a case where the lang is undefined and this case also use the same default language as defined in odoo en_US. As a result, the behaviour of event_session is more in line with the current behaviour in odoo which is to default to en_US if locale is undefined. With the global locale setting, the default locale would be the system one so it may give different result or strange behaviours or simply prevent correctly working without manual intervention on the host.. While babel is already supported and used by odoo. Modified the test to actually test correctly the date formatted As the default lang is en_US the format of a date is the following: - month/day/year And time format is on 12 hours so not 22:00 to 23:00 but 10:00 PM to 11:00 PM With those changes, setting the locale to en_UK,en_CA will render the correct date using - day/month/year and hours on 24h. Added tests to confirm the translations work correctly on some locales Check case when locale=None should default to en_US Check that lang change is correctly taken into account. Check that it works with languages returning unicode text (Russian)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-12.0/event-12.0-event_session Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-event_session/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-12.0/event-12.0-event_session Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-event_session/
When we create a session with seats_max = 0, we get an error when we try to view it. Doing this changes we achieve to avoid None values on the fields seats_available and seats_available_pc
Attendee count is failing because records are being accumulated without taking into account possible changes in event.registration With these changes, it is possible to correctly calculate the count of attendees. TT29930
ivantodorovich
force-pushed
the
15.0-mig-event-session
branch
from
764c088 to
68ff7c1
Compare
ivantodorovich
force-pushed
the
15.0-mig-event-session
branch
from
68ff7c1 to
d6d0d05
Compare
* Dropped the event_mail dependency, make it work with core mail schedulers instead. * Support core voucher / badge reports for sessions. * Now event.session inherits from event.event (like product.product and product.template) * Make it easier to add more sessions to an event (refactored wizard, using recurrency-like rules) * Play nice with regular events (events that don't use sessions) -- it's possible to have both kinds at the same time * Several UX improvements * Added more tests cases
ivantodorovich
force-pushed
the
15.0-mig-event-session
branch
from
d6d0d05 to
c385298
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
pedrobaeza
removed
the
stale
Member
|
@chienandalu can you please review this? |
Member
|
/ocabot migration event_session |
gregory-moka
approved these changes
Jan 27, 2023
Contributor
|
This PR has the |
Member
|
@chienandalu is it OK for you this refactoring? |
Member
|
Looks good (thanks for the work @ivantodorovich !), but I have to do an in depth review |
Contributor
Author
|
Thanks a lot @chienandalu :) |
Member
|
Should we merge then, @chienandalu, or are you going to do the review before the merge? |
Member
|
/ocabot merge nobump |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at df44210. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've done a huge refactoring to this module in order to support core features found in regular events, but also for sessions.
Some highlights:
event_maildependency, make it work with core mail schedulers instead.event.sessioninherits fromevent.event(likeproduct.productandproduct.template)eventfeatures with sessions, but nothing more.(and naturally there's also the
event_sale_sessionmodule, and some others to implement them in website and pos)@chienandalu I understand you're using this module in previous versions, and such a big change may not be welcomed. Consider this a RFC rather than a migration PR, to see if we can join forces