Skip to content

Conversation

@antespi
Copy link
Contributor

@antespi antespi commented Apr 18, 2016

This PR adds several improvements:

  • When registering a selection of partners, maybe an exception can be reised. Then no partner is registered, although exception is referred to only one of them. This is common when combined with addon event_registration_partner_unique. Now, wizard register each partner inside a database savepoint and when finished shows partners that couldn't be registered.
  • Change deprecated @api.one by @api.multi
  • Change registration partner data when partner form is updated (name, email and phone). But only if event is in future.

def write(self, data):
res = super(ResPartner, self).write(data)
for partner in self:
partner.registrations.partner_data_update(data)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make self.mapped('registrations').partner_data_update(data)

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.4%) to 90.391% when pulling 6f1df5c on Antiun:imp-partner_event into 713e75d on OCA:8.0.

@pedrobaeza
Copy link
Member

Tests for new features will be welcome.

@pedrobaeza
Copy link
Member

Check pylint

@antespi
Copy link
Contributor Author

antespi commented Apr 18, 2016

Fixes done, tests pending

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.04%) to 90.714% when pulling 42a4c9b on Antiun:imp-partner_event into 713e75d on OCA:8.0.

@oihane
Copy link

oihane commented Apr 18, 2016

LGTM 👍
Waiting for tests

@yajo
Copy link
Member

yajo commented Sep 12, 2016

Rebase please.

@rafaelbn rafaelbn added this to the 8.0 milestone Sep 12, 2016
@sergio-teruel
Copy link
Contributor

@antesti please rebase...

@pedrobaeza
Copy link
Member

This needs rebasing.

@antespi
Copy link
Contributor Author

antespi commented Nov 10, 2016

Travis is green now 😄

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runbot

@pedrobaeza pedrobaeza merged commit 0d9996d into OCA:8.0 Nov 11, 2016
cubells pushed a commit to Tecnativa/event that referenced this pull request Nov 12, 2016
pedrobaeza pushed a commit to Tecnativa/event that referenced this pull request Nov 25, 2016
AnilKesariya pushed a commit to AnilKesariya/event that referenced this pull request Oct 2, 2018
pedrobaeza pushed a commit to AnilKesariya/event that referenced this pull request Oct 24, 2018
pedrobaeza pushed a commit to AnilKesariya/event that referenced this pull request Mar 4, 2019
emagdalenaC2i pushed a commit to Change2improve/event that referenced this pull request Jun 30, 2019
* [ADD] Helpdesk: Añadida plantilla y función de envío de mail.

* [FIX] Fix the sending user email
victoralmau pushed a commit to Tecnativa/event that referenced this pull request Sep 7, 2020
Camille0907 pushed a commit to Camille0907/event that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants