-
-
Notifications
You must be signed in to change notification settings - Fork 714
[17.0][MIG] hr_employee_medical_examination: Migration to 17.0 #1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] hr_employee_medical_examination: Migration to 17.0 #1474
Conversation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-15.0/hr-15.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_medical_examination/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/
Currently translated at 58.6% (44 of 75 strings) Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/hr/
Currently translated at 100.0% (75 of 75 strings) Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Currently translated at 100.0% (75 of 75 strings) Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Currently translated at 100.0% (75 of 75 strings) Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Currently translated at 100.0% (75 of 75 strings) Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Currently translated at 100.0% (75 of 75 strings) Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/
Currently translated at 100.0% (76 of 76 strings) Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Currently translated at 100.0% (76 of 76 strings) Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Currently translated at 100.0% (76 of 76 strings) Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/
Currently translated at 98.6% (74 of 75 strings) Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/
Currently translated at 100.0% (77 of 77 strings) Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Currently translated at 100.0% (77 of 77 strings) Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/es/
Currently translated at 100.0% (77 of 77 strings) Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/es/
Currently translated at 100.0% (77 of 77 strings) Translation: hr-16.0/hr-16.0-hr_employee_medical_examination Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
d9a4da6 to
e9d40af
Compare
Abranes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review
| date = fields.Date( | ||
| string="Examination Date", | ||
| tracking=True, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this field could be a datetime because the examination usually takes place on a specific day and time. Maybe we could address it in a separate commit, or better yet in a PR after the migration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better in another PR after migration. Migrations must contain only version alignments.
hr_employee_medical_examination/tests/test_hr_employee_medical_examination.py
Outdated
Show resolved
Hide resolved
hr_employee_medical_examination/tests/test_hr_employee_medical_examination.py
Outdated
Show resolved
Hide resolved
e9d40af to
898bbe1
Compare
mymage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Abranes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
This PR has the |
|
/ocabot migration hr_employee_medical_examination |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at ad07392. Thanks a lot for contributing to OCA. ❤️ |
Standard migration to 17.0