Skip to content

Conversation

@Loregs2
Copy link

@Loregs2 Loregs2 commented Jun 5, 2025

Standard migration to 17.0

Jaime Arroyo and others added 30 commits June 5, 2025 13:49
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-15.0/hr-15.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_medical_examination/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/
Currently translated at 58.6% (44 of 75 strings)

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/hr/
Currently translated at 100.0% (75 of 75 strings)

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Currently translated at 100.0% (75 of 75 strings)

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Currently translated at 100.0% (75 of 75 strings)

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Currently translated at 100.0% (75 of 75 strings)

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Currently translated at 100.0% (75 of 75 strings)

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/
Currently translated at 100.0% (76 of 76 strings)

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Currently translated at 100.0% (76 of 76 strings)

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Currently translated at 100.0% (76 of 76 strings)

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/es/
oca-ci and others added 11 commits June 5, 2025 13:49
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/
Currently translated at 98.6% (74 of 75 strings)

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/
Currently translated at 100.0% (77 of 77 strings)

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
Currently translated at 100.0% (77 of 77 strings)

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/es/
Currently translated at 100.0% (77 of 77 strings)

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/es/
Currently translated at 100.0% (77 of 77 strings)

Translation: hr-16.0/hr-16.0-hr_employee_medical_examination
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_medical_examination/it/
@Loregs2 Loregs2 force-pushed the 17.0-mig-hr_employee_medical_examination branch from d9a4da6 to e9d40af Compare June 10, 2025 10:22
Copy link
Member

@Abranes Abranes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review

Comment on lines +30 to +33
date = fields.Date(
string="Examination Date",
tracking=True,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this field could be a datetime because the examination usually takes place on a specific day and time. Maybe we could address it in a separate commit, or better yet in a PR after the migration?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better in another PR after migration. Migrations must contain only version alignments.

@Loregs2 Loregs2 force-pushed the 17.0-mig-hr_employee_medical_examination branch from e9d40af to 898bbe1 Compare June 17, 2025 08:08
Copy link
Member

@mymage mymage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Abranes Abranes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Saran440
Copy link
Member

/ocabot migration hr_employee_medical_examination
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 18, 2025
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1474-by-Saran440-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jun 18, 2025
23 tasks
@OCA-git-bot OCA-git-bot merged commit a04631a into OCA:17.0 Jun 18, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ad07392. Thanks a lot for contributing to OCA. ❤️

@Abranes Abranes deleted the 17.0-mig-hr_employee_medical_examination branch June 18, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.