-
-
Notifications
You must be signed in to change notification settings - Fork 714
[17.0][MIG] hr_employee_id: Migration to 17.0 #1514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Management modules
Initial Attempt of a port to V8 Some improvements made are as follows: * Ability so choose ID generation method * Sequence vs Random hr_employee_id: code linting and copyright removals apply suggeste changes * Use identification_id provided by hr addon rather than employee_no * use new api in configuration * pep8 changes Update res_company.py make fields assignable from res_company add tests Remove duplicate license key import openerp.exception.Warning as UserWarning [FIX] import Warning as UserWarning
* Change .py header according OCA simple header * Add parameter name on field declaration * Greenify travis * Modify README.rst. Removing tabs from xml * Remove space from xml files * Make module installable
Currently translated at 53.3% (8 of 15 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/ar/
Currently translated at 100.0% (16 of 16 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/es/
Currently translated at 81.2% (13 of 16 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/de/
Currently translated at 81.2% (13 of 16 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/hr/
Currently translated at 100.0% (16 of 16 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/pt_BR/
o test default values even when company fields are false o test multi-company correctness
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-15.0/hr-15.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_id/
Currently translated at 100.0% (16 of 16 strings) Translation: hr-15.0/hr-15.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_id/it/
Currently translated at 100.0% (16 of 16 strings) Translation: hr-15.0/hr-15.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_id/it/
- Updated the create method in models/hr_employee.py to not break batch mode create
- Add test : test_generate_identification_id_exception
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-16.0/hr-16.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_id/
sanderlienaerts
approved these changes
Oct 15, 2025
sanderlienaerts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dreispt
approved these changes
Nov 8, 2025
Member
|
/ocabot migration hr_employee_id |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at da58cad. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported from #1466