Skip to content

Conversation

@chrisb-c01
Copy link

Backported from #1466

miketelahun and others added 30 commits October 14, 2025 16:50
Initial Attempt of a port to V8
Some improvements made are as follows:
* Ability so choose ID generation method
* Sequence vs Random

hr_employee_id: code linting and copyright removals

apply suggeste changes
* Use identification_id provided by hr addon rather than employee_no
* use new api in configuration
* pep8 changes

Update res_company.py

make fields assignable from res_company

add tests

Remove duplicate license  key

import openerp.exception.Warning as UserWarning

[FIX] import Warning as UserWarning
* Change .py header according OCA simple header
* Add parameter name on field declaration
* Greenify travis
* Modify README.rst. Removing tabs from xml
* Remove space from xml files
* Make module installable
Currently translated at 53.3% (8 of 15 strings)

Translation: hr-12.0/hr-12.0-hr_employee_id
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/ar/
Currently translated at 100.0% (16 of 16 strings)

Translation: hr-12.0/hr-12.0-hr_employee_id
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/es/
Currently translated at 81.2% (13 of 16 strings)

Translation: hr-12.0/hr-12.0-hr_employee_id
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/de/
Currently translated at 81.2% (13 of 16 strings)

Translation: hr-12.0/hr-12.0-hr_employee_id
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/hr/
Currently translated at 100.0% (16 of 16 strings)

Translation: hr-12.0/hr-12.0-hr_employee_id
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/pt_BR/
o test default values even when company fields are false
o test multi-company correctness
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-15.0/hr-15.0-hr_employee_id
Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_id/
Currently translated at 100.0% (16 of 16 strings)

Translation: hr-15.0/hr-15.0-hr_employee_id
Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_id/it/
Currently translated at 100.0% (16 of 16 strings)

Translation: hr-15.0/hr-15.0-hr_employee_id
Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_id/it/
- Updated the create method in models/hr_employee.py to not break batch mode create
Copy link

@sanderlienaerts sanderlienaerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreispt
Copy link
Member

dreispt commented Nov 8, 2025

/ocabot migration hr_employee_id
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 8, 2025
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1514-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Nov 8, 2025
23 tasks
@OCA-git-bot OCA-git-bot merged commit 31a4487 into OCA:17.0 Nov 8, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at da58cad. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.