Skip to content

Conversation

@mymage
Copy link
Member

@mymage mymage commented Oct 16, 2025

As in #1486
Changes the source of language list moving it from the res.lang.csv file to res.lang model.
In this way if you add a language at runtime it will be immediately available.

Added _compute_display_name (ex name_get) to show language name instead language code on selection or m2o widget

@mymage mymage changed the title [MOD][17.0] hr_employee_language: languages selection [MOD][18.0] hr_employee_language: languages selection Oct 16, 2025
@mymage mymage force-pushed the 18.0-mod-hr_employee_language branch 17 times, most recently from 2d3668b to 75eca3b Compare October 16, 2025 17:57
@mymage mymage marked this pull request as ready for review October 16, 2025 17:59
@mymage
Copy link
Member Author

mymage commented Oct 16, 2025

@dreispt @primes2h @TheMule71 plase review.
Little differences from #1512

@mymage
Copy link
Member Author

mymage commented Nov 10, 2025

@dreispt Thanks for your notes; I'm not so skilled on coding so your suggestion is very appreciated. I'll give a look asap.

@mymage mymage force-pushed the 18.0-mod-hr_employee_language branch 6 times, most recently from 72cb747 to 356ce99 Compare November 15, 2025 10:16
@mymage mymage force-pushed the 18.0-mod-hr_employee_language branch 6 times, most recently from bfff99a to ab2bd18 Compare November 16, 2025 20:56
@mymage
Copy link
Member Author

mymage commented Nov 16, 2025

@dreispt Thanks to your comments I refactored the code. The only "strange" thing that I made is this:
self_data = self.env["hr.employee.language"].search([]) for record in self_data:
to have CodeCov at 100%: this because despite I create an element in hr.employee.language for test, here self is empty.

@mymage mymage force-pushed the 18.0-mod-hr_employee_language branch from ab2bd18 to 87e51ec Compare November 19, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants