[18.0][MIG] mail_activity_reminder: Migration to 18.0 #36
Conversation
|
Hi @ellbristow, I would like to test this module. Could you please rebase it to reload the runboat? Thanks |
|
@ellbristow rebase? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
theangryangel
force-pushed
the
18.0-mig-mail_activity_reminder
branch
3 times, most recently
from
5988d00 to
e60984b
Compare
|
Apologies, this one fell by the wayside and we've just come across it whilst being asked to port this module to 19.0 😅 I've rebased this against the current 18.0 tip and squashed the MIG commits. We have been running this in production for some time. |
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
After the rebase, 'Files changed' tab looks weird. Looks like unrelated modules like mail_thread_create_nolog are added now.
|
/ocabot migration mail_activity_reminder |
|
There's no issue in this repo with the title 'Migration to version 18.0' and the milestone 18.0, so not possible to add the comment. |
|
Hello everyone, could this be merged? Seems like everything is ok? |
|
Looking at it there is something wrong with the rebase, it's bringing in other modules. I'm not 100% sure why or how myself or Elliott managed to screw that up. I'm not able to sort this today, but I will pop something in my calendar for Friday. |
theangryangel
force-pushed
the
18.0-mig-mail_activity_reminder
branch
2 times, most recently
from
0a4eb07 to
0520d0c
Compare
theangryangel
force-pushed
the
18.0-mig-mail_activity_reminder
branch
from
0520d0c to
fb7336b
Compare
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-16.0/social-16.0-mail_activity_reminder Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_reminder/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_activity_reminder Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_activity_reminder/
theangryangel
force-pushed
the
18.0-mig-mail_activity_reminder
branch
from
60920ef to
ed9e4bf
Compare
|
Should be sorted. Apologies for the noise this morning. New year brain haze :D |
16 participants
Migration to 18.0
Minor changes made to code for compatiblity (ir.cron fields no longer exist), and fixed unit tests
Installs correctly, all unit tests pass