[IMP] rewrite translatable strings to use named placeholders #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaule97
force-pushed
the
_improvements
branch
from
5dd0c12 to
509bf1b
Compare
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Really nice! Maybe you can improve the commit message (+ pr title) a little bit? Something like [IMP] rewrite translatable strings to use named placeholders.
Refactor translatable strings to use named placeholders instead of positional ones. This improves readability, reduces the risk of translation errors, and makes translations easier to maintain and reorder across languages.
chaule97
force-pushed
the
_improvements
branch
from
509bf1b to
6f5e19f
Compare
chaule97
changed the title
Author
|
Hallo @StefanRijnhart , I updated commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
odoo/odoo#52155
Starting from Odoo 14.0, the _() function supports named placeholders, which eliminates the need for manual string formatting like format() or %. I have written a script to convert old code to the new style.
convert
_("It's %s") % 2024,_("It's %s") % (2024),_("It's {}").format(2024)to_("It's %s", 2024)convert
_("User %(name)s has %(items)s items") % {"name":"Dev", "items": 5},_("User {name} has {items} items").format(name="Dev", items=5)to_("User %(name)s has %(items)s items", name="Dev", items=5)show warning if we use unnamed placeholders in translated string, example:
_("%s are only valid until %s", "User", 2024)