[IMP] Warning for _invalidate_cache() #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosd
approved these changes
Apr 12, 2025
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
_invalidate_cache is introduced in 16.0, so it won't have been used in modules before that. Shouldn´t it therefore go into migrate_160_always?
thienvh332
force-pushed
the
imp-warning
branch
from
ce95b01 to
59a1987
Compare
Author
|
Hi @StefanRijnhart , |
StefanRijnhart
approved these changes
Dec 25, 2025
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks for the update!
Contributor
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During migration, some developers might have naively replaced
invalidate_cache()with_invalidate_cache()=> We need to handle this specific case to avoid issues caused by changes in logic or the removal of private methods in the codebase