[ADD] Add warnings for new URL joining functions #151
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds migration warnings for the transition from Odoo 18.0 to 19.0, specifically targeting the deprecation of unsafe URL joining functions and encouraging migration to Odoo's new safer tools.urls.urljoin() function.
- Creates a YAML configuration file with pattern-based warnings for deprecated URL joining functions
- Establishes a migration script structure for the 18.0 to 19.0 transition
- Provides comprehensive coverage of various URL joining patterns from urllib.parse and werkzeug.urls
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| url_joining_functions.yaml | Defines regex patterns and warning messages for deprecated URL joining functions |
| migrate_180_190.py | Creates the base migration script class for 18.0 to 19.0 transitions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
odoo_module_migrate/migration_scripts/text_warnings/migrate_180_190/url_joining_functions.yaml
Outdated
Show resolved
Hide resolved
odoo_module_migrate/migration_scripts/text_warnings/migrate_180_190/url_joining_functions.yaml
Outdated
Show resolved
Hide resolved
odoo_module_migrate/migration_scripts/text_warnings/migrate_180_190/url_joining_functions.yaml
Outdated
Show resolved
Hide resolved
ced-adhoc
force-pushed
the
19.0-t-57439-ced
branch
3 times, most recently
from
b8f528f to
313b3b0
Compare
ced-adhoc
force-pushed
the
19.0-t-57439-ced
branch
from
313b3b0 to
b5b58d8
Compare
vib-adhoc
approved these changes
Sep 29, 2025
Contributor
|
LGTM |
StefanRijnhart
approved these changes
Dec 24, 2025
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Nice one! Tested functionally.
Contributor
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds migration warnings for the transition from Odoo 18.0 to 19.0 to help developers identify and update deprecated URL joining functions.
In Odoo 19.0, a new safer URL joining function was introduced in
odoo.tools.urls.urljoin()to replace potentially unsafe URL joining methods from external libraries.More information in Related Odoo commit: odoo/odoo@977e62d91f3e