[IMP] convert attrs attribute to attributes during v17 migration

[hbrunn]

this transforms

<field attrs={'required': [('field', '=', value)]}>

to

<field required="field == value" />

which is quite a pain to do manually

[legalsylvain]

thanks !

[StefanRijnhart]

Thanks!

It seems attrs="{'invisible': [('some_field', '=', True)]} is transformed to invisible="some_field == True". Can you make this invisible="some_field"?

[hbrunn]

@StefanRijnhart added that. At first, I deliberately didn't include handling the = True case here because a =/!= False domain leaf will be is (not) null in sql, which is guaranteed to map to falsiness/truthiness, while != True could be any truthy value that's not True. But then I think you're right and nobody uses it that way, so we're better off supporting the much more realistic case where this is used on boolean fields

[StefanRijnhart]

Thanks, boolean issue is now solved. Next issue I now encounter is attrs with newlines in the XML.

                <attribute name="attrs">{'invisible': ['|', '|', '&amp;',                                                                                                                     
                    ('picking_type_code', '!=', 'outgoing'),                                                                                                                                  
                    ('some_field', '=', False),                                                                                                                                          
                    ('state', 'in', ('draft', 'cancel')),                                                                                                                                     
                    ('other_field', '=', False)]}                                                                                                                                               
                </attribute>

Such a snippet leads to

  File "/home/venv/py3.12-test3/lib/python3.12/site-packages/odoo_module_migrate/migration_scripts/migrate_160_170.py", line 361, in attrs_to_attributes
    attrs_expression = ast.parse(attrs_string, mode="eval")
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/.pyenv/versions/3.12.9/lib/python3.12/ast.py", line 52, in parse
    return compile(source, filename, mode, flags,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<unknown>", line 6
    
IndentationError: unexpected indent

[hbrunn]

@StefanRijnhart thank you for battle testing this, fixed

[StefanRijnhart]

Thanks, working well now!