[18.0][FIX][IMP] product_pricelist_supplierinfo: Fixes and refactoring #2177
+139
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @luisg123v, |
Instead of trying to get the product context, we must use the `product.pricelist.item` context to get the filtered partner
Odoo's pricelist computation is now correctly split, so we override the base price computation instead of the full price and we let Odoo compute surcharge/discount/etc.
- Function signature of `_get_supplierinfo_pricelist_price` updated to match `PriceList._compute_price_rule`
- Also drop support to get "UoM" and "date" from context
(see Odoo commit 57ced812f099bec67bade265fd592160ad5690a2: [REF] product: clean pricelist API )
- Improve test on different UoM:
- Add `price_surcharge` to the UoM test
- Add an intermediate UoM (half-dozen) to ensure valid results when the wanted UoM
is not one of the product's default (uom_id, uom_po_id)
…n improved to cover more cases
ypapouin
force-pushed
the
18.0-product_pricelist_supplierinfo-refactoring
branch
from
9f88a8e to
3c1aed7
Compare
Contributor
Author
|
@CLaurelB can you please take a look on this since you did the 18.0 migration ? (#1837) |
Contributor
|
Thanks @ypapouin code LGTM. I will check how to incorporate this to v19, a refactor was done for the v19 migration and it is not a straightforward forward port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and improvements for Odoo 18.0 (this PR is based on a closed PR I previously made for Odoo 14.0 #1357)
product.pricelist.itemcontext to get the filtered partner. The current implementation is broken, a new test is added to ensure that it works correctly now.