-
-
Notifications
You must be signed in to change notification settings - Fork 535
[ADD] queue_job module: migration from 9.0 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Curious - what's the rationale behind including the major version migrations here vs OpenUpgrade? If it's something fully supported by OCA, we migrate in the module? |
|
It's simple, this should be executed when this module gets upgraded. We can't include this in OpenUpgrade if we want to keep the modularity, or we will fill OpenUpgrade with a lot of |
|
Totally makes sense, thanks Pedro |
|
@pedrobaeza @cubells @rafaelbn You must revert this merge! The queue_job addon doesn't depend on 'connector' and don't exist in 9.0. |
|
This is for 10.0, not for 9.0. |
|
@pedrobaeza yes but how would that work? queue_job is a new addon in 10.0 so you'd install it and the migration won't be called. And if it is called you might not have the |
|
This will only be activated on migrations, not on regular installation, so there's no problem. |
These changes are needed to upgrade connector module to 10.0
cc @Tecnativa