Skip to content

[12.0][IMP] - keep connexion alive in case of job inactivity #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 1 commit into from
Aug 10, 2020
Merged

[12.0][IMP] - keep connexion alive in case of job inactivity #249

OCA-git-bot merged 1 commit into from
Aug 10, 2020

Conversation

@sbejaoui
Copy link
Contributor

@sbejaoui sbejaoui commented Jul 24, 2020

fixes: #246

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jul 24, 2020

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@guewen
Copy link
Member

guewen commented Jul 24, 2020

@sbejaoui Is my understanding correct that it will wait for notifications 60 seconds, then if nothing happened, execute the keep-alive and listen again for 60 seconds?

@sbejaoui
Copy link
Contributor Author

sbejaoui commented Jul 24, 2020

@sbejaoui Is my understanding correct that it will wait for notifications 60 seconds, then if nothing happened, execute the keep-alive and listen again for 60 seconds?

yes that's the point

guewen
guewen approved these changes Jul 25, 2020
View reviewed changes
Copy link
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbejaoui

@guewen
Copy link
Member

guewen commented Aug 10, 2020

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 10, 2020

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-249-by-guewen-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 10, 2020
@OCA-git-bot
Merge PR #249 into 12.0
4061b19 
Signed-off-by guewen
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 10, 2020

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-249-by-guewen-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 07d0df4 into OCA:12.0 Aug 10, 2020
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 10, 2020

Congratulations, your PR was merged at be4cc22. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 12.0-issue_246-sbj branch August 10, 2020 08:47
@agent-z28 agent-z28 mentioned this pull request Sep 11, 2020
Closed
@guewen guewen mentioned this pull request Sep 30, 2020
Merged
@moylop260 moylop260 mentioned this pull request Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guewen guewen guewen approved these changes

@sbidoul sbidoul sbidoul approved these changes

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbejaoui @OCA-git-bot @guewen @sbidoul