Do not save session in /queue_job/runjob route #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @guewen, |
Member
|
Much less code, I love it :) |
simahawk
approved these changes
Oct 2, 2020
Contributor
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
not tested but the change seems legit
lmignon
approved these changes
Oct 2, 2020
Contributor
lmignon
left a comment
lmignon
left a comment
There was a problem hiding this comment.
No test but if the functionality is provided by Odoo ...
Member
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at a089cb1. Thanks a lot for contributing to OCA. ❤️ |
StefanRijnhart
pushed a commit
to VanMoof/queue
that referenced
this pull request
Aug 20, 2021
Backport from OCA#252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since odoo/odoo@f65528a routes have a
save_sessionoption.We can simplify the job runner by making use of it.
This is currently lUNTESTED.