Skip to content

Conversation

@kittiu
Copy link
Member

@kittiu kittiu commented Sep 27, 2020

Just add a pending TODO from sale_automatic_workflow_job

closes: #238

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@guewen
Copy link
Member

guewen commented Oct 1, 2020

Thanks, I would appreciate if you keep my authorship though :)

If you have changes to do in the commit, you can add in the commit's body: Co-authored-by: name <name@example.com>
As described in https://docs.github.com/en/free-pro-team@latest/github/committing-changes-to-your-project/creating-a-commit-with-multiple-authors

@kittiu
Copy link
Member Author

kittiu commented Oct 1, 2020

Thanks, I would appreciate if you keep my authorship though :)

If you have changes to do in the commit, you can add in the commit's body: Co-authored-by: name <name@example.com>
As described in https://docs.github.com/en/free-pro-team@latest/github/committing-changes-to-your-project/creating-a-commit-with-multiple-authors

Sure! Let me study for it. :)

Co-authored-by: Guewen Baconnier <guewen.baconnier@camptocamp.com>
@kittiu kittiu force-pushed the 13.0-enh-queue_job-add_decorator_job_auto_delay branch from e6167e6 to 8ec6ae7 Compare October 2, 2020 04:16
@kittiu
Copy link
Member Author

kittiu commented Oct 2, 2020

Sure! Let me study for it. :)

Done

)

def auto_delay(self, *args, **kwargs):
if self.env.context.get("job_uuid") or self.env.context.get("_job_force_sync"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittiu IMO it's very important to have a unitttest for this new useful functionality

@guewen
Copy link
Member

guewen commented Oct 29, 2020

@kittiu I proposed an alternative on #270 with tests and a correction in the method + added test_queue_job_no_delay

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 30, 2022
@github-actions github-actions bot closed this Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Add job_auto_delay decorator

5 participants