-
-
Notifications
You must be signed in to change notification settings - Fork 536
[13.0][IMP] queue_job, add decorator job_auto_delay #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][IMP] queue_job, add decorator job_auto_delay #255
Conversation
|
Hi @guewen, |
|
Thanks, I would appreciate if you keep my authorship though :) If you have changes to do in the commit, you can add in the commit's body: |
Sure! Let me study for it. :) |
Co-authored-by: Guewen Baconnier <guewen.baconnier@camptocamp.com>
e6167e6 to
8ec6ae7
Compare
Done |
| ) | ||
|
|
||
| def auto_delay(self, *args, **kwargs): | ||
| if self.env.context.get("job_uuid") or self.env.context.get("_job_force_sync"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe better to use the same key as here? https://github.com/OCA/queue/blob/13.0/queue_job/models/base.py#L89
lmignon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kittiu IMO it's very important to have a unitttest for this new useful functionality
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Just add a pending TODO from sale_automatic_workflow_job
closes: #238